<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115910/">https://git.reviewboard.kde.org/r/115910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 20th, 2014, 4:59 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115910/diff/1/?file=245042#file245042line1032" style="color: black; font-weight: bold; text-decoration: underline;">kwin/screenedge.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1032</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">bordersLeft</span> <span class="o">||</span> <span class="n">bordersRight</span><span class="p">)</span> <span class="o">&&</span> <span class="n">geo</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span class="o">></span> <span class="n">geo</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think this is "wrong".
you're trying to detect the orientation of the panel, but the client likely *knows* the orientation of the panel (and where to activate it) - eg. old kicker (bottom panel) could collapse horizontally.
imo the client should tell kwin where to (preferably) add the border (through the client message)
internal heuristics could only serve as failsafe for lazy clients.</pre>
</blockquote>
<p>On February 20th, 2014, 6:25 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah yes the client message, that could work. Client message got added after that code part got written, so it didn't occur to me ;-)</pre>
</blockquote>
<p>On February 20th, 2014, 6:50 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder whether the client message should rather be replaced by a property?
It would cover the "kwin restarted" situation as well as be more robust against races (plasma starts before kwin) and also export the condition to other clients.</pre>
</blockquote>
<p>On February 20th, 2014, 7:16 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I first tried with a property, but the problem is that there is no way for the client to propagate that it should get hidden. So in the end I had property and the client message in addition resulting in the property being ignored all the time. Thus I removed it again.
The KWin restarted situation is in my opinion quite well handled by having the client being shown again. And it's a corner case, our users shouldn't restart KWin ;-)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The client could set the property when it wants to be hidden (and also hint on which edge to add the trigger)
When showing it, kwin would withdraw the property and withdrawing the property could be used by the client to indicate "show me again" (because the user turned it into a permanent panel or whatever)</pre>
<br />
<p>- Thomas</p>
<br />
<p>On February 20th, 2014, 1:51 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 1:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screenedge show support for Clients
This provides a new protocol intended to be used by auto-hiding panels
to make use of the centralized screen edges. To use it a Client can
send a client message of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
KWin will hide the Client (hide because unmap or minimize would break
it) and create an Edge. If that Edge gets triggered the Client is shown
again. If the Client doesn't border a screen edge the Client gets shown
immediately so that we never end in a situation that we cannot unhide
the auto-hidden panel again. The exact process is described in the
documentation of ScreenEdges.
If KWin gets restarted the Client gets shown again.
As this is a KWin specific extension we need to discuss what it means
for Clients using this feature with other WMs: it does nothing. As
the Client gets hidden by KWin and not by the Client, it just doesn't
get hidden if the WM doesn't provide the feature. In case of an
auto-hiding panel this seems like a good solution given that we don't
want to hide it if we cannot unhide it. Of course there's the option
for the Client to provide that feature itself and if that's wanted we
would need to announce the feature in the _NET_SUPPORTED atom. At the
moment that doesn't sound like being needed as Plasma doesn't want to
provide an own implementation.
The implementation comes with a small test application showing how
the feature is intended to be used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/atoms.h <span style="color: grey">(1690067c5d1da59f38f9e77ef64eacfbc1faa0cf)</span></li>
<li>kwin/atoms.cpp <span style="color: grey">(904f5efe4a32e3673dae9e6da92bf4336def660d)</span></li>
<li>kwin/client.cpp <span style="color: grey">(36431bfc33418a207de12fa8cc95a35539256366)</span></li>
<li>kwin/events.cpp <span style="color: grey">(1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18)</span></li>
<li>kwin/screenedge.h <span style="color: grey">(60f5fd669ccc5eb627feffa460552558d1765b31)</span></li>
<li>kwin/screenedge.cpp <span style="color: grey">(04cf0d6d5262ab84d88559b6dc85e099efec77bf)</span></li>
<li>kwin/tests/CMakeLists.txt <span style="color: grey">(3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14)</span></li>
<li>kwin/tests/screenedgeshowtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>