<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Martin,<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">Am 16.02.2014 17:41, schrieb Martin
Klapetek:<br>
</div>
<blockquote
cite="mid:CAPLgePrMagKzxGsd0a1uzTMuBrGWjypONv7p5+Kg-7dFWrkArA@mail.gmail.com"
type="cite">
<div dir="ltr">Hey,
<div><br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
---------- Forwarded message ----------<br>
From: Conny Marco Menebröcker <<a
moz-do-not-send="true"
href="mailto:admin@menebroecker-web.de">admin@menebroecker-web.de</a>><br>
Date: Sat, Feb 15, 2014 at 7:44 PM<br>
Subject: Request for review<br>
To: <a moz-do-not-send="true"
href="mailto:kde-devel@kde.org">kde-devel@kde.org</a><br>
<br>
<br>
Hello all,<br>
<br>
<br>
I have written my first plasmoid. I called it
PlasmaTaskViewer,<br>
because it views the todos of a calendar file.<br>
In my case it shows the entries of my iPhone reminder
app.<br>
<br>
I would be happy if someone reviews my code. I am
especially<br>
interested in comments about the use of kcalcore and the
data engine.<br>
But every other comment is welcome, too.<br>
</blockquote>
<div><br>
</div>
<div>I just did a quick look over your code and tried to
build it. You'll need to explicitly look for KdepimLibs
+ set include_dirs in order to build everywhere with no
problems. Attached is a simple patch fixing the build. </div>
<div> </div>
</div>
</div>
</div>
</div>
</blockquote>
Thank you very much for the patch and your comments.<br>
Yesterday, I checked in your patch.<br>
<br>
<blockquote
cite="mid:CAPLgePrMagKzxGsd0a1uzTMuBrGWjypONv7p5+Kg-7dFWrkArA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>I tried running it but have no .ics files present so
can't really try it out. Though your configuration
dialog is somewhat too small and cannot be resized
easily for some reason. One more comment on the visuals
- if I add the applet is added on the desktop and you
have no data/must set it up first, it should show some
label what to do, otherwise it's just an empty
Plasma-themed rectangle sitting on your desktop :)</div>
</div>
</div>
</div>
</div>
</blockquote>
I already noticed the issue with the configuration dialog, but
couldn't figure out how to fix it, yet.<br>
I will add the label with one of my next changes.<br>
<blockquote
cite="mid:CAPLgePrMagKzxGsd0a1uzTMuBrGWjypONv7p5+Kg-7dFWrkArA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>Final note, we do not really support Applets based on
QGraphicsView anymore, the proper way to go is to use
QML, which is way superior in tech and ease of writing.
I think this[1] should be a good way to get you started
:)</div>
</div>
</div>
</div>
</div>
</blockquote>
I will read the tutorial and decide afterwards, if I will change
something.<br>
I don't know much about QML, I thought it was only a specific
programming language for QT development.<br>
So, currently I don't understand the advantage. But we will see.<br>
<br>
<blockquote
cite="mid:CAPLgePrMagKzxGsd0a1uzTMuBrGWjypONv7p5+Kg-7dFWrkArA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>[1] - <a moz-do-not-send="true"
href="http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted">http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted</a></div>
<div><br>
</div>
</div>
<div>Cheers</div>
-- <br>
<div><span style="color:rgb(102,102,102)">Martin Klapetek |
KDE Developer</span></div>
</div>
</div>
</div>
</blockquote>
<br>
Best regards,<br>
<br>
Conny<br>
</body>
</html>