<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115764/">https://git.reviewboard.kde.org/r/115764/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Sinny Kumari and Sujith Haridasan.</div>
<div>By Shantanu Tushar.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous.
This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with usual playback and with passing multiple files as command line parameters.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/playlistmodel.cpp <span style="color: grey">(9c1dea9)</span></li>
<li>mediaelements/playlist/MultiplePlaylists.qml <span style="color: grey">(d94fe6e)</span></li>
<li>mediaelements/playlist/Playlist.qml <span style="color: grey">(fd83c21)</span></li>
<li>mediaelements/playlist/PlaylistDelegate.qml <span style="color: grey">(e1bd31d)</span></li>
<li>shells/newshell/application.cpp <span style="color: grey">(adc95dc)</span></li>
<li>shells/newshell/mainwindow.h <span style="color: grey">(d918e3d)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(7f7f31d)</span></li>
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: grey">(b6cb87c)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.h <span style="color: grey">(06b64df)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.cpp <span style="color: grey">(f2c9246)</span></li>
<li>libs/mediacenter/playlistmodel.h <span style="color: grey">(f79f814)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115764/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>