<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115698/">https://git.reviewboard.kde.org/r/115698/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bada0c97ba38fc60e3262ae69b43334768c5db47 by Martin Gräßlin to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On February 12th, 2014, 1:09 p.m. UTC, Martin Gräßlin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>


<p style="color: grey;"><i>Updated Feb. 12, 2014, 1:09 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensure that we can build without X11 or XCB

* X11 is optional dependency
* XCB is optional dependency
* Qt::X11Extras is only found if both X11 and XCB are found
* switch to HAVE_X11 instead of X11_FOUND in CMakeLists
* remove/fix custom added definitions
* use #if HAVE_X11 instead of #ifdef HAVE_X11 (that is always true)

Change is on top of review 115641</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled with and without XLib</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(7803274f34d22d2af57011cfbca0f3b888f93580)</span></li>

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: grey">(2ea89b3d13324b6e43dfdf281c10a49fafe5a5e5)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: grey">(81b4672f1651a98e61f874a748c2fde9b5b0f1b1)</span></li>

 <li>src/declarativeimports/core/dialogshadows.cpp <span style="color: grey">(5a0ee82576e61430a1e7a330a5ad973ef75067c9)</span></li>

 <li>src/plasma/CMakeLists.txt <span style="color: grey">(9679cc96f82a85f75dbfc6df5790c269a821dcb9)</span></li>

 <li>src/plasma/private/componentinstaller.cpp <span style="color: grey">(4f70baa9c667530f76df8edb9cee1373cfad2d4c)</span></li>

 <li>src/shell/CMakeLists.txt <span style="color: grey">(5fbbf874a090ecc4b99b35598fe9214b914f3584)</span></li>

 <li>src/shell/panelshadows.cpp <span style="color: grey">(d2fa85bb8644d0d610e69c26c0fad7828868d277)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115698/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>