<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115447/">https://git.reviewboard.kde.org/r/115447/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine as far as the behavior is concerned.
However on a personal note, I am very scared of the complexity we are bringing with this as well as the complexity we have from review #114892. Hope we can get rid of all this and do these in a much cleaner way some day.</pre>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On February 3rd, 2014, 3:53 p.m. UTC, Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2014, 3:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch should be applied on branch remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help to add songs or videos to an already running instance ( or the single instance ) of pmc. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Launch dolphin.
2) Start playing a song or video by clicking open with option in dolphin.
3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter.
4) User can see them automatically added to "Misc" playlist.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/application.cpp <span style="color: grey">(2d1901b)</span></li>
<li>libs/mediacenter/playlistmodel.cpp <span style="color: grey">(4b3cbc4)</span></li>
<li>shells/newshell/mainwindow.h <span style="color: grey">(3810fa0)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(b9671c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>