<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115475/">https://git.reviewboard.kde.org/r/115475/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 4th, 2014, 3:33 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Splitted out KRunner so we can use it from any solution and eventually move out from it, if required.
It can be found now in kde:scratch/apol/krunner.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything still builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/includes/Plasma/RunnerScript <span style="color: grey">(f078d03)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(4d8633c)</span></li>
<li>src/plasma/private/abstractrunner_p.h <span style="color: grey">(ada3222)</span></li>
<li>src/plasma/private/runnerjobs.cpp <span style="color: grey">(880a3c5)</span></li>
<li>src/plasma/private/runnerjobs_p.h <span style="color: grey">(43c6da2)</span></li>
<li>src/plasma/private/storage.cpp <span style="color: grey">(c9d7100)</span></li>
<li>src/plasma/querymatch.h <span style="color: grey">(7fe66fb)</span></li>
<li>src/plasma/querymatch.cpp <span style="color: grey">(8353e8f)</span></li>
<li>src/plasma/runnercontext.h <span style="color: grey">(97d654a)</span></li>
<li>src/plasma/runnercontext.cpp <span style="color: grey">(8b74614)</span></li>
<li>src/plasma/runnermanager.h <span style="color: grey">(1963f66)</span></li>
<li>src/plasma/runnermanager.cpp <span style="color: grey">(69f8ef4)</span></li>
<li>src/plasma/runnersyntax.h <span style="color: grey">(63a2624)</span></li>
<li>src/plasma/runnersyntax.cpp <span style="color: grey">(2984d7a)</span></li>
<li>src/plasma/scripting/runnerscript.h <span style="color: grey">(1175d25)</span></li>
<li>src/plasma/scripting/runnerscript.cpp <span style="color: grey">(366d3ef)</span></li>
<li>src/plasma/scripting/scriptengine.h <span style="color: grey">(013e983)</span></li>
<li>src/plasma/scripting/scriptengine.cpp <span style="color: grey">(2a0dfd9)</span></li>
<li>src/scriptengines/python/CMakeLists.txt <span style="color: grey">(2bd980b)</span></li>
<li>src/plasma/includes/Plasma/RunnerContext <span style="color: grey">(0c0d283)</span></li>
<li>src/plasma/includes/Plasma/RunnerManager <span style="color: grey">(95e00ec)</span></li>
<li>src/declarativeimports/krunnermodel/qmldir <span style="color: grey">(6e4fe5b)</span></li>
<li>src/declarativeimports/krunnermodel/runnermodelplugin.h <span style="color: grey">(65d2faa)</span></li>
<li>src/declarativeimports/krunnermodel/runnermodelplugin.cpp <span style="color: grey">(3b466bf)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(064d3cc)</span></li>
<li>src/plasma/abstractrunner.h <span style="color: grey">(219fa05)</span></li>
<li>src/plasma/abstractrunner.cpp <span style="color: grey">(c01ac18)</span></li>
<li>src/plasma/autotests/CMakeLists.txt <span style="color: grey">(06c3d15)</span></li>
<li>src/plasma/autotests/runnercontexttest.h <span style="color: grey">(1c6feb7)</span></li>
<li>src/plasma/autotests/runnercontexttest.cpp <span style="color: grey">(bb38d3e)</span></li>
<li>src/plasma/data/servicetypes/plasma-runner.desktop <span style="color: grey">(08cd066)</span></li>
<li>src/plasma/includes/Plasma/AbstractRunner <span style="color: grey">(fbc77e8)</span></li>
<li>src/plasma/includes/Plasma/QueryMatch <span style="color: grey">(d6fc700)</span></li>
<li>examples/runner/homefilesrunner.cpp <span style="color: grey">(39d0205)</span></li>
<li>examples/runner/plasma-runner-example-homefiles.desktop <span style="color: grey">(296d1d0)</span></li>
<li>src/declarativeimports/CMakeLists.txt <span style="color: grey">(db88828)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: grey">(1ce43d4)</span></li>
<li>src/declarativeimports/core/runnermodel.h <span style="color: grey">(bd21c21)</span></li>
<li>src/declarativeimports/core/runnermodel.cpp <span style="color: grey">(170f511)</span></li>
<li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: grey">(b49f91d)</span></li>
<li>src/declarativeimports/core/tests/main.cpp <span style="color: grey">(1feee19)</span></li>
<li>src/declarativeimports/krunnermodel/CMakeLists.txt <span style="color: grey">(f7405b6)</span></li>
<li>examples/runner/CMakeLists.txt <span style="color: grey">(b9c1511)</span></li>
<li>examples/runner/Messages.sh <span style="color: grey">(4fb602e)</span></li>
<li>examples/runner/homefilesrunner.h <span style="color: grey">(c535380)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115475/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>