<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115004/">https://git.reviewboard.kde.org/r/115004/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me. </pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On January 13th, 2014, 8:02 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2014, 8:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDeclarative has very generic class names, therefore a bad practiche for public symbols.
this moves it under KDeclarative:: namespace as discussed in the sprint</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/configpropertymap.h <span style="color: grey">(aeb41b5)</span></li>
<li>src/configpropertymap.cpp <span style="color: grey">(73e21d8)</span></li>
<li>src/kdeclarative.h <span style="color: grey">(84e8df4)</span></li>
<li>src/kdeclarative.cpp <span style="color: grey">(8aed99c)</span></li>
<li>src/private/kdeclarative_p.h <span style="color: grey">(91e83cc)</span></li>
<li>src/private/kiconprovider.cpp <span style="color: grey">(27eb8d1)</span></li>
<li>src/private/kiconprovider_p.h <span style="color: grey">(3773e0c)</span></li>
<li>src/private/kioaccessmanagerfactory.cpp <span style="color: grey">(ea73c45)</span></li>
<li>src/private/kioaccessmanagerfactory_p.h <span style="color: grey">(7f7cc73)</span></li>
<li>src/private/qmlobject_p.h <span style="color: grey">(e5b32f8)</span></li>
<li>src/private/rootcontext.cpp <span style="color: grey">(503b430)</span></li>
<li>src/private/rootcontext_p.h <span style="color: grey">(805f7fa)</span></li>
<li>src/qmlobject.h <span style="color: grey">(5028559)</span></li>
<li>src/qmlobject.cpp <span style="color: grey">(d00ff40)</span></li>
<li>tests/kdeclarativetest.cpp <span style="color: grey">(dd34d88)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115004/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>