<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114892/">https://git.reviewboard.kde.org/r/114892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2014, 6:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes the following issues addressed in the previous review:
a) When a file played through command line or Dolphin, the focus gets automatically to "Misc" playlist.
b) Removed the config setting mentioned by shantanu and implemented it in other way. Let me know if this solution sounds ok.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PMC can play songs from the command line or when selected from file browsers like Dolphin( using "Open With" ). PMC creates a separate playlist called "Misc" which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one ("Misc"). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Open pmc from the command line (or from Dolphin) with multiple files to be opened:
1) PMC starts playing the songs/videos with the ones passed.
With Dolphin I have tested with only one file and it worked properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(b2793df)</span></li>
<li>mediaelements/playlist/MultiplePlaylists.qml <span style="color: grey">(42877f0)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.h <span style="color: grey">(30b317b)</span></li>
<li>libs/mediacenter/playlistmodel.cpp <span style="color: grey">(00a0cee)</span></li>
<li>libs/mediacenter/playlistmodel.h <span style="color: grey">(3993ac3)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.cpp <span style="color: grey">(d52fa66)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114892/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>