<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114912/">https://git.reviewboard.kde.org/r/114912/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replace use of KSharedPtr with a QWeakPointer and QSharedPointer in Plasma::Svg.
This removes the last dependency from plasma-framework on kde4support.
This change is a bit more involved than other kde4support removals because QSharedPointer does not provide a count() method. I therefore reworked the code to store the SharedSvgRenderer as a QWeakPointer in s_renderers, making it possible to detect when the last one goes away by creating a QWeakPointer guard in SvgPrivate::eraseRenderer().
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8b60011)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(aced599)</span></li>
<li>src/plasma/private/svg_p.h <span style="color: grey">(5fdebf3)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(6542b34)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114912/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>