<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114493/">http://git.reviewboard.kde.org/r/114493/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114493/diff/1/?file=225200#file225200line81" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_add_ui_files</span> <span class="err">(PlasMate_SRC</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_add_ui_files</span> <span class="err">(PlasMate_SRC</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ki18n_wrap_ui or somesuch?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114493/diff/1/?file=225200#file225200line89" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">include_directories</span><span class="p">(</span><span class="o">${</span><span class="nv">QT_QTWEBKIT_INCLUDE_DIR</span><span class="o">}</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">include_directories</span><span class="p">(</span><span class="o">${</span><span class="nv">QT_QTWEBKIT_INCLUDE_DIR</span><span class="o">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the webkit include shouldn't be necessary here, but done by the buildsystem</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114493/diff/1/?file=225200#file225200line100" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">100</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">plasmate</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">plasmate</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please go over the variable names here, and make them use the correct KF5:: names</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114493/diff/1/?file=225200#file225200line161" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c">#install(TARGETS plasmaremoteinstaller ${INSTALL_TARGETS_DEFAULT_ARGS})</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">139</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err">kde4_add_ui_files</span> <span class="err">(PlasmaRemoteInstaller_SRC</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ki18n_wrap_ui</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114493/diff/1/?file=225200#file225200line183" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">170</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span class="hl">#</span>add_executable(kwin-windowswitcherpreviewer ${KWin-WindowSwitcherPreviewer_SRC})</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">161</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err"><span class="hl">kde4_</span>add_executable(kwin-windowswitcherpreviewer</span> <span class="err">${KWin-WindowSwitcherPreviewer_SRC})</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add_executable is fine here</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've noted a few things, but noticed something else (actually, bshah did): Is the patch generated correctly? It ports some occurrences of add_executable to kde4_add_executable, which is exactly the wrong way around?</pre>
<p>- Sebastian Kügler</p>
<br />
<p>On December 16th, 2013, 9:21 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 9:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks branch.
Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d6219a)</span></li>
<li>engineexplorer/CMakeLists.txt <span style="color: grey">(ce0dd6a)</span></li>
<li>engineexplorer/engineexplorer.cpp <span style="color: grey">(1f1b868)</span></li>
<li>engineexplorer/serviceviewer.cpp <span style="color: grey">(924e4c9)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(55e7453)</span></li>
<li>plasmate/docbrowser/docbrowser.h <span style="color: grey">(dc91936)</span></li>
<li>plasmate/docbrowser/docbrowser.cpp <span style="color: grey">(d14eea1)</span></li>
<li>plasmate/editors/editpage.h <span style="color: grey">(56a1982)</span></li>
<li>plasmate/editors/editpage.cpp <span style="color: grey">(d260585)</span></li>
<li>plasmate/editors/imageviewer/imageloader.h <span style="color: grey">(aafaed0)</span></li>
<li>plasmate/editors/imageviewer/imageloader.cpp <span style="color: grey">(f45ca74)</span></li>
<li>plasmate/editors/imageviewer/imageviewer.h <span style="color: grey">(2bfbaa5)</span></li>
<li>plasmate/editors/imageviewer/imageviewer.cpp <span style="color: grey">(d9f9d43)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.h <span style="color: grey">(0043051)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.cpp <span style="color: grey">(13598b7)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.ui <span style="color: grey">(5483351)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtreader.cpp <span style="color: grey">(9d6346c)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtwriter.cpp <span style="color: grey">(9bda29d)</span></li>
<li>plasmate/editors/kconfigxt/standalone/main.cpp <span style="color: grey">(8fb83ee)</span></li>
<li>plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp <span style="color: grey">(a7e8294)</span></li>
<li>plasmate/editors/metadata/CMakeLists.txt <span style="color: grey">(602aca9)</span></li>
<li>plasmate/editors/metadata/metadataeditor.cpp <span style="color: grey">(a8a744a)</span></li>
<li>plasmate/editors/metadata/tests/test_metadata.cpp <span style="color: grey">(fd8ad93)</span></li>
<li>plasmate/editors/svg/CMakeLists.txt <span style="color: grey">(0214310)</span></li>
<li>plasmate/editors/svg/svgviewer.cpp <span style="color: grey">(469b3ff)</span></li>
<li>plasmate/editors/svg/tests/test_svg.cpp <span style="color: grey">(bc725ab)</span></li>
<li>plasmate/konsole/konsolepreviewer.cpp <span style="color: grey">(e7b38e2)</span></li>
<li>plasmate/main.cpp <span style="color: grey">(3de6fa8)</span></li>
<li>plasmate/mainwindow.h <span style="color: grey">(844ef60)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(890ad56)</span></li>
<li>plasmate/modeltest/dynamictreemodel.h <span style="color: grey">(4ba4a8e)</span></li>
<li>plasmate/modeltest/dynamictreemodel.cpp <span style="color: grey">(b2f23ea)</span></li>
<li>plasmate/modeltest/modeltest.h <span style="color: grey">(b347221)</span></li>
<li>plasmate/modeltest/modeltest.cpp <span style="color: grey">(cf21835)</span></li>
<li>plasmate/packagemodel.h <span style="color: grey">(4c546c5)</span></li>
<li>plasmate/packagemodel.cpp <span style="color: grey">(dc3e42f)</span></li>
<li>plasmate/previewer/plasmoid/CMakeLists.txt <span style="color: grey">(b75bb41)</span></li>
<li>plasmate/previewer/plasmoid/previewcontainment.h <span style="color: grey">(43de4b8)</span></li>
<li>plasmate/previewer/plasmoid/previewcontainment.cpp <span style="color: grey">(4449ce7)</span></li>
<li>plasmate/previewer/plasmoid/test/CMakeLists.txt <span style="color: grey">(4e8649a)</span></li>
<li>plasmate/previewer/plasmoid/test/main.cpp <span style="color: grey">(6a30bdd)</span></li>
<li>plasmate/previewer/windowswitcher/standalone/main.cpp <span style="color: grey">(b30d57a)</span></li>
<li>plasmate/previewer/windowswitcher/standalone/windowswitcherpreviewer.h <span style="color: grey">(3a43af8)</span></li>
<li>plasmate/previewer/windowswitcher/standalone/windowswitcherpreviewer.cpp <span style="color: grey">(55d0d8a)</span></li>
<li>plasmate/previewer/windowswitcher/tabboxpreviewer.cpp <span style="color: grey">(2606582)</span></li>
<li>plasmate/previewer/windowswitcher/thumbnailitem.h <span style="color: grey">(2721044)</span></li>
<li>plasmate/previewer/windowswitcher/thumbnailitem.cpp <span style="color: grey">(6d03078)</span></li>
<li>plasmate/previewer/windowswitcher/windowswitcher.h <span style="color: grey">(c5c3d13)</span></li>
<li>plasmate/previewer/windowswitcher/windowswitcher.cpp <span style="color: grey">(6d544a5)</span></li>
<li>plasmate/projectmanager/projectmanager.h <span style="color: grey">(645dffe)</span></li>
<li>plasmate/projectmanager/projectmanager.cpp <span style="color: grey">(e291ed1)</span></li>
<li>plasmate/publisher/publisher.h <span style="color: grey">(92e80cd)</span></li>
<li>plasmate/publisher/publisher.cpp <span style="color: grey">(529bd2e)</span></li>
<li>plasmate/publisher/publisher.ui <span style="color: grey">(a149949)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.h <span style="color: grey">(efb28fe)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.cpp <span style="color: grey">(5f4de97)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.ui <span style="color: grey">(67d868f)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: grey">(7317eaf)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: grey">(3b41b33)</span></li>
<li>plasmate/publisher/remoteinstaller/standalone/main.cpp <span style="color: grey">(c82e4b2)</span></li>
<li>plasmate/publisher/signingwidget.h <span style="color: grey">(939d1d8)</span></li>
<li>plasmate/publisher/signingwidget.cpp <span style="color: grey">(3b65544)</span></li>
<li>plasmate/savesystem/commitdialog.h <span style="color: grey">(c41836b)</span></li>
<li>plasmate/savesystem/commitdialog.cpp <span style="color: grey">(9a6ecc3)</span></li>
<li>plasmate/savesystem/dvcsjob.h <span style="color: grey">(77838ec)</span></li>
<li>plasmate/savesystem/dvcsjob.cpp <span style="color: grey">(bd88b24)</span></li>
<li>plasmate/savesystem/gitrunner.h <span style="color: grey">(3171b82)</span></li>
<li>plasmate/savesystem/gitrunner.cpp <span style="color: grey">(9b4a03e)</span></li>
<li>plasmate/savesystem/test/CMakeLists.txt <span style="color: grey">(706c330)</span></li>
<li>plasmate/savesystem/test/main.cpp <span style="color: grey">(aa987c3)</span></li>
<li>plasmate/savesystem/timeline.h <span style="color: grey">(b58a72d)</span></li>
<li>plasmate/savesystem/timeline.cpp <span style="color: grey">(f4454fd)</span></li>
<li>plasmate/sidebartablewidget.cpp <span style="color: grey">(c9980e1)</span></li>
<li>plasmate/startpage.h <span style="color: grey">(d466fa7)</span></li>
<li>plasmate/startpage.cpp <span style="color: grey">(a1d707a)</span></li>
<li>plasmate/startpage.ui <span style="color: grey">(c0c232a)</span></li>
<li>plasmate/test-kpart/CMakeLists.txt <span style="color: grey">(761afcd)</span></li>
<li>plasmate/test-kpart/main.cpp <span style="color: grey">(9d67674)</span></li>
<li>plasmate/test-kpart/mainwindow.h <span style="color: grey">(ea517b3)</span></li>
<li>plasmate/test-kpart/mainwindow.cpp <span style="color: grey">(a18a66a)</span></li>
<li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(30de8e2)</span></li>
<li>plasmoidviewer/fullview.h <span style="color: grey">(7d4c70d)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(898931a)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(f3cdb22)</span></li>
<li>plasmoidviewer/qmlpackages/containment/Messages.sh <span style="color: grey">(c8a9b60)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js <span style="color: grey">(62e149a)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/config/main.xml <span style="color: grey">(d889999)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml <span style="color: grey">(b23e098)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml <span style="color: grey">(33d72c0)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/main.qml <span style="color: grey">(6558710)</span></li>
<li>plasmoidviewer/qmlpackages/containment/metadata.desktop <span style="color: grey">(9ddd217)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Background.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: grey">(e5bedf3)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/view.h <span style="color: grey">(0e2e48c)</span></li>
<li>plasmoidviewer/view.cpp <span style="color: grey">(fc008b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>