<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114428/">http://git.reviewboard.kde.org/r/114428/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2013, 7:53 a.m. UTC, <b>Sujith Haridasan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114428/diff/2/?file=224654#file224654line42" style="color: black; font-weight: bold; text-decoration: underline;">mediaelements/mediawelcome/HomeScreenFooter.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kd">var</span> <span class="nx">d</span> <span class="o">=</span> <span class="k">new</span> <span class="nb">Date</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span class="nx">headerTimeText</span><span class="p">.</span><span class="nx">text</span> <span class="o">=</span><span class="nx">Qt</span><span class="p">.</span><span class="nx">formatDate</span><span class="p">(</span> <span class="nx">dataSource</span><span class="p">.</span><span class="nx">data</span><span class="p">[</span><span class="s2">"Local"</span><span class="p">][</span><span class="s2">"Date"</span><span class="p">],</span><span class="s2">"dddd dd MMM yyyy"</span> <span class="p">)</span><span class="o">+</span><span class="s2">"\n"</span><span class="o">+</span><span class="nx">Qt</span><span class="p">.</span><span class="nx">formatTime</span><span class="p">(</span> <span class="nx">dataSource</span><span class="p">.</span><span class="nx">data</span><span class="p">[</span><span class="s2">"Local"</span><span class="p">][</span><span class="s2">"Time"</span><span class="p">],</span><span class="s2">"hh:mm AP"</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The PMC time doesn't get synced with desktop time. Can you tune this further to get it synced?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also, this is the matter of #114429 . This review should only be about Text -> Label. Heena can you update the diff?</pre>
<br />
<p>- Shantanu</p>
<br />
<p>On December 13th, 2013, 7:24 a.m. UTC, Heena Mahour wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.</div>
<div>By Heena Mahour.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 7:24 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replaced Text {} by PlasmaComponents.Label {} </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">works fine .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/BackendsListDelegate.qml <span style="color: grey">(e76af63)</span></li>
<li>mediaelements/mediawelcome/HomeScreenFooter.qml <span style="color: grey">(d2c0eb7)</span></li>
<li>mediaelements/mediawelcome/HomeScreenText.qml <span style="color: grey">(35cd20a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114428/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>