<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114389/">http://git.reviewboard.kde.org/r/114389/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3214bd8132afdf263197d4de6903912f5e536cfd by Martin Klapetek to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 10th, 2013, 4:51 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 4:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Follows the lib renaming of frameworks
Puts KF5 in the lib name --> libKF5Plasma & libKF5PlasmaQuick as well as the packages --> KF5Plasma and KF5PlasmaQuick.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None atm, the rest of plasma-framework needs updating to the renamed frameworks first, there is a script in making which should do that, so I'll hold on that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>PlasmaConfig.cmake.in <span style="color: grey">(6331882)</span></li>
<li>PlasmaMacros.cmake <span style="color: grey">()</span></li>
<li>examples/dataengines/customDataContainers/CMakeLists.txt <span style="color: grey">(7029f93)</span></li>
<li>examples/dataengines/simpleEngine/CMakeLists.txt <span style="color: grey">(ee6edd4)</span></li>
<li>examples/dataengines/sourcesOnRequest/CMakeLists.txt <span style="color: grey">(d4557f5)</span></li>
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: grey">(89fa122)</span></li>
<li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: grey">(0a90003)</span></li>
<li>src/declarativeimports/krunnermodel/CMakeLists.txt <span style="color: grey">(cd64357)</span></li>
<li>src/declarativeimports/plasmacomponents/CMakeLists.txt <span style="color: grey">(012f652)</span></li>
<li>src/declarativeimports/plasmaextracomponents/CMakeLists.txt <span style="color: grey">(c06d81e)</span></li>
<li>src/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: grey">(aa44ae9)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(3ab0596)</span></li>
<li>src/plasma/autotests/CMakeLists.txt <span style="color: grey">(77c9f6c)</span></li>
<li>src/plasma/tests/kplugins/CMakeLists.txt <span style="color: grey">(ebdba66)</span></li>
<li>src/plasmapkg/CMakeLists.txt <span style="color: grey">(7eb41d8)</span></li>
<li>src/plasmaquick/CMakeLists.txt <span style="color: grey">(c361df2)</span></li>
<li>src/plasmaquick/PlasmaQuickConfig.cmake.in <span style="color: grey">(5b258a2)</span></li>
<li>src/plasmaquick/autotests/CMakeLists.txt <span style="color: grey">(1fc3adf)</span></li>
<li>src/scriptengines/qml/CMakeLists.txt <span style="color: grey">(3d7bd41)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(faa51e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114389/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>