<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114388/">http://git.reviewboard.kde.org/r/114388/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think I was not quite clear enough here, and caused a misunderstanding.
We should make the scripting support OPTIONAL, instead of REQUIRED. I hoped to be able to do that without #ifdef, by just not including a subdirectory, for example. Seems this isn't possible here, and we'd actually cause a BIC change whether webkit is found or not. That's not good, as it causes non-obvious build problems (i.e. the thing we wanted to avoid).
If it's not possible without #ifdef or BIC change, disable the whole library based on webkit being found or not. That will make it a whole lot cleaner and clearer to the user.
Sorry for causing confusion here. :/</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On December 10th, 2013, 4:54 p.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 4:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on IRC #kde-devel</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9841bbd)</span></li>
<li>libs/ksysguard/processui/CMakeLists.txt <span style="color: grey">(07ddbef)</span></li>
<li>libs/ksysguard/processui/ksysguardprocesslist.h <span style="color: grey">(97116be)</span></li>
<li>libs/ksysguard/processui/ksysguardprocesslist.cpp <span style="color: grey">(0f6220f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114388/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>