<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114253/">http://git.reviewboard.kde.org/r/114253/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Dec. 5, 2013, 7:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QString instead of QUrl for the identifier so we have two different identifiers for different urls for the same host (e.g. http://kde.org and kde.org). The current engine does this way.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I replaced KUrl by QUrl and KStandardDirs by QStandardPaths. Also I cleanup includes.
The url given in input could be absolute or relative but not local, then I used QUrl::fromUserInput().</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I try to fetch several favicons an empty image is returned, except the first one which contains a valid favicon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/favicons/favicons.cpp <span style="color: grey">(2eae673)</span></li>
<li>plasma/generic/dataengines/favicons/favicons.h <span style="color: grey">(79565bf)</span></li>
<li>plasma/generic/dataengines/favicons/faviconprovider.cpp <span style="color: grey">(bc72a66)</span></li>
<li>plasma/generic/dataengines/favicons/faviconprovider.h <span style="color: grey">(1f370f9)</span></li>
<li>plasma/generic/dataengines/CMakeLists.txt <span style="color: grey">(3e94325)</span></li>
<li>plasma/generic/dataengines/favicons/CMakeLists.txt <span style="color: grey">(4af0f14)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114253/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>