<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113920/">http://git.reviewboard.kde.org/r/113920/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it here locally. Building plasma-shell against it and running it is a pretty good test to pick up regressions, on top of the existing unit tests. None observed, though.</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On November 19th, 2013, 9:58 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2013, 9:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stop using classes from kde4support:
- KComponentData is deprecated, it will be using QCoreApplication::applicationName() and QCoreApplication::applicationVersion(). Of course this means that the existing shells will have to be ported. I have no problem with doing that port myself, if I'm told where to look into.
- Drop usage of KLocale, ported to QLocale
- Drop usage of KStandardDirs, ported to QStandardPaths
- Drop usage of KIcon, ported to QIcon
Furthermore, there's a module in src/declarativeimports/locale that IIUC exposes KLocale bindings to QML. A specific plan to port it should happen as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.
I'm unsure what else to test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a9da457)</span></li>
<li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: grey">(da0dbc5)</span></li>
<li>src/declarativeimports/core/tests/sortfiltermodeltest.cpp <span style="color: grey">(93ffba4)</span></li>
<li>src/declarativeimports/locale/CMakeLists.txt <span style="color: grey">(6aecb84)</span></li>
<li>src/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span style="color: grey">(2c64b7f)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(c227a15)</span></li>
<li>src/plasma/private/dataenginemanager.cpp <span style="color: grey">(1c235e0)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(c19dbd2)</span></li>
<li>src/shell/activity.cpp <span style="color: grey">(2523397)</span></li>
<li>src/shell/scripting/appinterface.cpp <span style="color: grey">(63196f9)</span></li>
<li>src/shell/scripting/scriptengine.cpp <span style="color: grey">(1250c20)</span></li>
<li>src/shell/shellcorona.cpp <span style="color: grey">(2519e29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113920/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>