<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113920/">http://git.reviewboard.kde.org/r/113920/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 18th, 2013, 7:15 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113920/diff/1/?file=214752#file214752line148" style="color: black; font-weight: bold; text-decoration: underline;">src/shell/activity.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Activity::removed()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">148</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QFile</span><span class="o">::</span><span class="n">remove</span><span class="p">(</span><span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locateLocal</span><span class="p">(</span><span class="s">"appdata"</span><span class="p">,</span> <span class="n">name</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">147</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QFile</span><span class="o">::</span><span class="n">remove</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">writableLocation</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">DataLocation</span><span class="p">)</span><span class="o">+</span><span class="n">QChar</span><span class="p">(</span><span class="sc">'/'</span><span class="p">)</span><span class="o">+</span><span class="n">name</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QDir::separator() instead of QChar('/') here to avoid unixism.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See http://qt-project.org/doc/qt-5.0/qtcore/qdir.html#separator</pre>
<br />
<p>- Aleix</p>
<br />
<p>On November 18th, 2013, 5:17 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 5:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stop using classes from kde4support:
- KComponentData is deprecated, it will be using QCoreApplication::applicationName() and QCoreApplication::applicationVersion(). Of course this means that the existing shells will have to be ported. I have no problem with doing that port myself, if I'm told where to look into.
- Drop usage of KLocale, ported to QLocale
- Drop usage of KStandardDirs, ported to QStandardPaths
- Drop usage of KIcon, ported to QIcon
Furthermore, there's a module in src/declarativeimports/locale that IIUC exposes KLocale bindings to QML. A specific plan to port it should happen as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.
I'm unsure what else to test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a9da457)</span></li>
<li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: grey">(da0dbc5)</span></li>
<li>src/declarativeimports/core/tests/sortfiltermodeltest.cpp <span style="color: grey">(93ffba4)</span></li>
<li>src/declarativeimports/locale/CMakeLists.txt <span style="color: grey">(6aecb84)</span></li>
<li>src/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span style="color: grey">(2c64b7f)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(c227a15)</span></li>
<li>src/plasma/private/dataenginemanager.cpp <span style="color: grey">(1c235e0)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(c19dbd2)</span></li>
<li>src/shell/activity.cpp <span style="color: grey">(2523397)</span></li>
<li>src/shell/scripting/appinterface.cpp <span style="color: grey">(63196f9)</span></li>
<li>src/shell/scripting/scriptengine.cpp <span style="color: grey">(1250c20)</span></li>
<li>src/shell/shellcorona.cpp <span style="color: grey">(2519e29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113920/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>