<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113078/">http://git.reviewboard.kde.org/r/113078/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this review is less about the actual code in this review and more about the design of the system monitor in general.
currently the main applet embeds the other applets; this obviously won't work in the QML2 world. so each of the small applets really needs to become an individual QML item that can be re-used in both individual applets and in combination with each other. to that end, my proposal is this:
* create a QML import that contains all of the monitors as individual QML items.
* create a stand-alone plasmoid that wraps those monitors
* design a way to allow the kind of scripting/control that we see in popular packages like conkie to allow re-use of these components; perhaps the best way to do this would be to provide a small designer tool that would let one define the order of components and what they should be showing which would then export a finished plasmoid implementing that design.</pre>
<br />
<p>- Aaron J. Seigo</p>
<br />
<p>On October 3rd, 2013, 4:03 p.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2013, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">start porting system monitor applet, step 1 hwinfo applet</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">works as expected.. requires bit UI change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: grey">(2e9a390)</span></li>
<li>plasma/generic/applets/system-monitor/CMakeLists.txt <span style="color: grey">(002e1db)</span></li>
<li>plasma/generic/applets/system-monitor/hwinfo/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/system-monitor/hwinfo/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/system-monitor/plasma-applet-sm_hwinfo.desktop <span style="color: grey">(aa31f89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113078/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>