<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113086/">http://git.reviewboard.kde.org/r/113086/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 4th, 2013, 11:42 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking good, lots of incremental improvements, too.
I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly after you've committed this one.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ow, the test you mention can just be disabled. It probably needs rewriting, at least, it has to move into plasma-framework.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On October 3rd, 2013, 8:02 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2013, 8:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reorganizes the file structure as the KF5 module suggest.
Adopts newer syntaxes for defining dependencies.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
There's a test that tests things that are not part either of this module or its dependencies:
import Qt 4.7
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3204c11)</span></li>
<li>experimental/CMakeLists.txt <span style="color: grey">(e73a8c4)</span></li>
<li>experimental/COPYING <span style="color: grey">(5185fd3)</span></li>
<li>experimental/COPYING.LIB <span style="color: grey">(2d2d780)</span></li>
<li>experimental/CTestConfig.cmake <span style="color: grey">(c383ee1)</span></li>
<li>experimental/KDELibsExperimentalNightly.cmake <span style="color: grey">(fd53e0c)</span></li>
<li>experimental/kdeclarative/CMakeLists.txt <span style="color: grey">(72ea7a2)</span></li>
<li>experimental/kdeclarative/bindings/backportglobal.h <span style="color: grey">(fca8ade)</span></li>
<li>experimental/kdeclarative/bindings/i18n.cpp <span style="color: grey">(75a67aa)</span></li>
<li>experimental/kdeclarative/bindings/i18n_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/bindings/icon.cpp <span style="color: grey">(dbdc8fe)</span></li>
<li>experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp <span style="color: grey">(919e889)</span></li>
<li>experimental/kdeclarative/bindings/url.cpp <span style="color: grey">(3031a6f)</span></li>
<li>experimental/kdeclarative/config-kdeclarative.h.cmake <span style="color: grey">(611c678)</span></li>
<li>experimental/kdeclarative/configpropertymap.h <span style="color: grey">(c9ef3ae)</span></li>
<li>experimental/kdeclarative/configpropertymap.cpp <span style="color: grey">(373a655)</span></li>
<li>experimental/kdeclarative/kdeclarative.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/kdeclarative.cpp <span style="color: grey">(63ae180)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfig.cmake.in <span style="color: grey">(d68008a)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in <span style="color: grey">(eae2225)</span></li>
<li>experimental/kdeclarative/private/kdeclarative_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/kiconprovider.cpp <span style="color: grey">(8506b8b)</span></li>
<li>experimental/kdeclarative/private/kiconprovider_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext.cpp <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.cpp <span style="color: grey">(ee81b41)</span></li>
<li>experimental/kdeclarative/qmlobject_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/test/test.cpp <span style="color: grey">(3986b77)</span></li>
<li>experimental/kdeclarative/test/test.qml <span style="color: grey">(060c265)</span></li>
<li>experimental/kdeclarative/test/testobject_p.h <span style="color: grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(5c5c80c)</span></li>
<li>staging/kdeclarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/KDeclarativeConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>