<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113086/">http://git.reviewboard.kde.org/r/113086/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing serious, just some nitpicking.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113086/diff/1/?file=193824#file193824line260" style="color: black; font-weight: bold; text-decoration: underline;">staging/kdeclarative/src/bindings/backportglobal.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">260</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">target</span> <span class="o">=</span> <span class="n">reinterpret_cast</span><span class="o"><</span><span class="n">T</span><span class="o">*></span><span class="p">(</span><span class="n">qobj</span><span class="o">-></span><span class="n">qt_metacast</span><span class="p">(</span><span class="n">typeName</span><span class="p">.</span><span class="n">left</span><span class="p">(</span><span class="n">typeName</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span class="o">-</span><span class="mi">1</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">260</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">target</span> <span class="o">=</span> <span class="n">reinterpret_cast</span><span class="o"><</span><span class="n">T</span><span class="o">*></span><span class="p">(</span><span class="n">qobj</span><span class="o">-></span><span class="n">qt_metacast</span><span class="p">(</span><span class="n">typeName</span><span class="p">.</span><span class="n">left</span><span class="p">(</span><span class="n">typeName</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span class="o">-</span><span class="mi">1</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">constData</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing spaces in `typeName.size()-1` and trailing space after .const.
Would be more readable to move typeName.left(...) to its own var.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113086/diff/1/?file=193843#file193843line105" style="color: black; font-weight: bold; text-decoration: underline;">staging/kdeclarative/src/qmlobject.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qWarning</span><span class="p">()</span> <span class="o"><<</span> <span class="n">component</span><span class="o">-></span><span class="n">url</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span class="o"><span class="hl">+</span></span> <span class="sc">'\n'</span> <span class="o"><span class="hl">+</span></span> <span class="n">errorStr</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qWarning</span><span class="p">()</span> <span class="o"><<</span> <span class="n">component</span><span class="o">-></span><span class="n">url</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span class="o"><span class="hl"><<</span></span> <span class="sc">'\n'</span> <span class="o"><span class="hl"><<</span></span> <span class="n">errorStr</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not exactly the same: if I am not mistaken, qWarning() will add extra spaces and maybe quotes around the '\n'.</pre>
</div>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On October 3rd, 2013, 10:02 p.m. CEST, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2013, 10:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reorganizes the file structure as the KF5 module suggest.
Adopts newer syntaxes for defining dependencies.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
There's a test that tests things that are not part either of this module or its dependencies:
import Qt 4.7
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3204c11)</span></li>
<li>experimental/CMakeLists.txt <span style="color: grey">(e73a8c4)</span></li>
<li>experimental/COPYING <span style="color: grey">(5185fd3)</span></li>
<li>experimental/COPYING.LIB <span style="color: grey">(2d2d780)</span></li>
<li>experimental/CTestConfig.cmake <span style="color: grey">(c383ee1)</span></li>
<li>experimental/KDELibsExperimentalNightly.cmake <span style="color: grey">(fd53e0c)</span></li>
<li>experimental/kdeclarative/CMakeLists.txt <span style="color: grey">(72ea7a2)</span></li>
<li>experimental/kdeclarative/bindings/backportglobal.h <span style="color: grey">(fca8ade)</span></li>
<li>experimental/kdeclarative/bindings/i18n.cpp <span style="color: grey">(75a67aa)</span></li>
<li>experimental/kdeclarative/bindings/i18n_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/bindings/icon.cpp <span style="color: grey">(dbdc8fe)</span></li>
<li>experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp <span style="color: grey">(919e889)</span></li>
<li>experimental/kdeclarative/bindings/url.cpp <span style="color: grey">(3031a6f)</span></li>
<li>experimental/kdeclarative/config-kdeclarative.h.cmake <span style="color: grey">(611c678)</span></li>
<li>experimental/kdeclarative/configpropertymap.h <span style="color: grey">(c9ef3ae)</span></li>
<li>experimental/kdeclarative/configpropertymap.cpp <span style="color: grey">(373a655)</span></li>
<li>experimental/kdeclarative/kdeclarative.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/kdeclarative.cpp <span style="color: grey">(63ae180)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfig.cmake.in <span style="color: grey">(d68008a)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in <span style="color: grey">(eae2225)</span></li>
<li>experimental/kdeclarative/private/kdeclarative_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/kiconprovider.cpp <span style="color: grey">(8506b8b)</span></li>
<li>experimental/kdeclarative/private/kiconprovider_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext.cpp <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.cpp <span style="color: grey">(ee81b41)</span></li>
<li>experimental/kdeclarative/qmlobject_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/test/test.cpp <span style="color: grey">(3986b77)</span></li>
<li>experimental/kdeclarative/test/test.qml <span style="color: grey">(060c265)</span></li>
<li>experimental/kdeclarative/test/testobject_p.h <span style="color: grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(5c5c80c)</span></li>
<li>staging/kdeclarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/KDeclarativeConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>