<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112888/">http://git.reviewboard.kde.org/r/112888/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2013, 9:47 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/applets/icon/plugin/icon_p.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_INVOKABLE</span> <span class="n">QString</span> <span class="n">getGenericName</span><span class="p">(</span><span class="k">const</span> <span class="n">QUrl</span><span class="o">&</span> <span class="n">url</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem more declarative.
This would also make the "remote" case easier, when you have to stat a remote file asynchronously and only know details after the network request.</pre>
</blockquote>
<p>On September 23rd, 2013, 12:02 p.m. UTC, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passing url is my main problem here..</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd add a writable property url, which then updates all the other properties via property bindings. </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2013, 9:47 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line76" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/applets/icon/plugin/icon_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no new line</pre>
</blockquote>
<p>On September 23rd, 2013, 11:56 a.m. UTC, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">??</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">} else {
not
}
else {</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 23rd, 2013, 8:26 a.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Marco Martin and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 8:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port Icon applet to plasma2
Some issues..
-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Compiles
2) Installs
3) Loads
-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet.
4) Opens URL - Clicking on the icon applet opens url with kfmclient</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: grey">(4ace449)</span></li>
<li>plasma/generic/applets/icon/CMakeLists.txt <span style="color: grey">(1094666)</span></li>
<li>plasma/generic/applets/icon/icon.h <span style="color: grey">(45fa07c)</span></li>
<li>plasma/generic/applets/icon/icon.cpp <span style="color: grey">(8288850)</span></li>
<li>plasma/generic/applets/icon/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plasma-applet-icon.desktop <span style="color: grey">(8275ddd)</span></li>
<li>plasma/generic/applets/icon/plugin/icon_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/icon_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/iconplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/iconplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/icon/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112888/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png">icons in panel</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png">icons as launcher</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png">files</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png">folders</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>