<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112208/">http://git.reviewboard.kde.org/r/112208/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've installed the applet, and had a look in more detail. It's coming along really nicely, and already feels a lot better than the QWidget-based kmix. :)
Some issues I've found:
- Resizing the popup dialog doesn't resize its content, this leads to unfriendly resizing on the one hand, and clipping of the list of channel items on the other
- The listview is draggable when it doesn't have to be, use something like interactive: height < contentsHeight in the ListView to prevent that from happening
- The vertical view needs definitely more spacing, if we really want to keep it
- Some spacing would do the listview good, this leads to better grouping of the channel items
- The item name isn't properly anchored and should either determine the minimum width, or be elided
- The percentage on the left hand side should not be bold
- The slider feels a bit jerky, this is probably the event round-tripping Xetuan mentions, see that part of the thread
- The speaker icon feels a bit weird to mute the channel, I think that's because it's used with different semantics for the applet as well: open mixer (the panel icon). Maybe it could be done with a checkbox, and possibly moved to the top-right, so that the layout
- The initial values in the config dialog are not set up correctly. Try switching to master channel only, OK, reopen config dialog: it's set to show all channels. Haven't checked if this is also the case for the orientation
- Show all mixers -> "Show all Channels" (i.e. does "mixer" make sense here, or is it really a channel, or a "Volume Control"?
- "Mixer slider orientation" -> "Orientation" ?
Overall, nice work. This is good stuff. =)</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On August 27th, 2013, 8:40 a.m. UTC, Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2013, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against master and works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/VerticalControl.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112208/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png">Default look</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png">Menu Actions</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png">Applet Config Options</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png">Vertical Control</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png">ToolButton label and Config page after updates</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png">Control Icon and Label left aligned</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>