<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112447/">http://git.reviewboard.kde.org/r/112447/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch creates a new library out of the shell dir.
We need this library in order to implement plasmoidviewer 2.0</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code is locate at git@git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git .
how to test it
* git clone git@git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git
* cd pf5
* git checkout split7
* build it and install it
* use plasma-shell
I haven't noticed any issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(281d146)</span></li>
<li>src/plasmaview/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/PlasmaViewConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/configview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/configview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/containmentconfigview_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/containmentconfigview_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/currentcontainmentactionsmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/currentcontainmentactionsmodel_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/includes/PlasmaView/ConfigView <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/includes/PlasmaView/ContainmentConfigView <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/includes/PlasmaView/ShellPluginLoader <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/includes/PlasmaView/View <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/shellpackage_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/shellpackage_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/shellpluginloader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/shellpluginloader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmaview/view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(3da019f)</span></li>
<li>src/shell/configview.h <span style="color: grey">(2e8f68f)</span></li>
<li>src/shell/configview.cpp <span style="color: grey">(fea5a73)</span></li>
<li>src/shell/containmentconfigview.h <span style="color: grey">(619fa14)</span></li>
<li>src/shell/containmentconfigview.cpp <span style="color: grey">(235a33f)</span></li>
<li>src/shell/currentcontainmentactionsmodel.h <span style="color: grey">(db94da1)</span></li>
<li>src/shell/currentcontainmentactionsmodel.cpp <span style="color: grey">(c955bef)</span></li>
<li>src/shell/shellcorona.cpp <span style="color: grey">(ffdbfe8)</span></li>
<li>src/shell/shellpackage.h <span style="color: grey">(99dc460)</span></li>
<li>src/shell/shellpackage.cpp <span style="color: grey">(74aea5c)</span></li>
<li>src/shell/shellpluginloader.h <span style="color: grey">(1d3dade)</span></li>
<li>src/shell/shellpluginloader.cpp <span style="color: grey">(8b2e1dd)</span></li>
<li>src/shell/view.h <span style="color: grey">(7e6b2d9)</span></li>
<li>src/shell/view.cpp <span style="color: grey">(a0c6168)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>