<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112208/">http://git.reviewboard.kde.org/r/112208/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2013, 3:38 p.m. UTC, <b>Igor Poboiko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png" style="color: black; font-weight: bold; font-size: 9pt;">Vertical Control</a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we need it?
(there is volume level percentage under the tooltip)
It isn't consistent with horizontal view where there is no such label. Also it duplicates the information from slider. And also it reacts pretty slow to the changes when user moves the slider (due to slowness of the chain plasma->dbus->kmix->backend->kmix->dbus->plasma), which is pretty frustrating.
A label (or a tooltip maybe?) with device name would be nice, because it is pretty hard to decide what volume am I changing when there are multiple cards (or just input and output sliders like in PulseAudio).</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tooltpis are gone in rev2, see sebas comment ;)
The reason I didn't used a label with this layout is that it would take sooo much space but sure, this is an issue that must be addressed because the user must know which control he/she's going to modify ... I'll try to play with some wrapMode Label properties and see if I can get something usable and good looking.</pre>
<br />
<p>- Diego</p>
<br />
<p>On August 24th, 2013, 3:11 p.m. UTC, Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 3:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against master and works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/kmix-applet-qml/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/ButtonBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/MixersList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/VerticalControl.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/kmixapplet.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/kmix-applet-qml/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112208/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png">Default look</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png">Menu Actions</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png">Applet Config Options</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png">Vertical Control</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png">ToolButton label and Config page after updates</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>