<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112150/">http://git.reviewboard.kde.org/r/112150/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c84b6017dee805cb38238b5155449f9f6f3553cb by David Edmundson to branch frameworks-scratch.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 18th, 2013, 10:28 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2013, 10:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
Git log below
--
Restore config for clock applet
--
Remove calendar components.
Plasma will have it's own Calendar which should be shared
--
Scale clock hands to fit current clock size
--
Update copyright to reflect actual authors
--
Port analog clock to new dataengine + config scheme
Make the clock use the new PlasmaCore.Datasource to fetch the current
time
--
Update the analog clock to run on plasma 2
--
Enable generic/applets directory
--
Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/analog-clock/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Calendar.qml <span style="color: grey">(60da3f7)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Cell.qml <span style="color: grey">(2f0376a)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Hand.qml <span style="color: grey">(eaa7a9b)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/analogclock.qml <span style="color: grey">(ad03f18)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>