<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112150/">http://git.reviewboard.kde.org/r/112150/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2013, 1:47 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112150/diff/1/?file=183342#file183342line92" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/applets/analog-clock/contents/ui/analogclock.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">z:</span> <span class="mi">1000</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could this be made relative, i.e. z: secondHand.z + 1 ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think we would gain anything in this case.
z on the second hand will still be the default 0 regardless of how many overlapping objects it is in front of. So this would always be the same as just z:1.
The only benefit we would get is if someone explicitly sets a z-index on secondHand, but doing that would be as bad as what I've done here.</pre>
<br />
<p>- David</p>
<br />
<p>On August 18th, 2013, 10:28 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2013, 10:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
Git log below
--
Restore config for clock applet
--
Remove calendar components.
Plasma will have it's own Calendar which should be shared
--
Scale clock hands to fit current clock size
--
Update copyright to reflect actual authors
--
Port analog clock to new dataengine + config scheme
Make the clock use the new PlasmaCore.Datasource to fetch the current
time
--
Update the analog clock to run on plasma 2
--
Enable generic/applets directory
--
Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/analog-clock/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Calendar.qml <span style="color: grey">(60da3f7)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Cell.qml <span style="color: grey">(2f0376a)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/Hand.qml <span style="color: grey">(eaa7a9b)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/analogclock.qml <span style="color: grey">(ad03f18)</span></li>
<li>plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>