<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108325/">http://git.reviewboard.kde.org/r/108325/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 5th, 2013, 4:16 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please attach the diff properly and not give ship its to yourself?
I'd suggest you discard this review that is already broken and start a new one where you attach the diff properly and you don't give you a ship it to yourself and then maybe others will have a look at it.</pre>
</blockquote>
<p>On April 5th, 2013, 4:20 p.m. UTC, <b>Leszek Lesner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I would know hot to attach the diff properly I would have done it. It is just not recognizing the patch. </pre>
</blockquote>
<p>On April 5th, 2013, 6 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What error are you getting? How are you creating the patch?</pre>
</blockquote>
<p>On April 5th, 2013, 6:22 p.m. UTC, <b>Leszek Lesner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I got the error that this is not a patch or that the specified diff file is empty.
I created the patch with dpkg-source --commit and removed the description lines above.</pre>
</blockquote>
<p>On April 5th, 2013, 6:31 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">dpkg-source --commit seems like a bad way to create a git compatible diff.
Just do "git diff" on the git repo.</pre>
</blockquote>
<p>On April 5th, 2013, 6:52 p.m. UTC, <b>Leszek Lesner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm... I did not have any git repo there. I just downloaded the sources directly. Maybe that was the whole mistake.
But it is some month already ago that I created that patch and it should be mostly outdated now that we have 4.10.2 out.
All in all I am a little bit unhappy that I posted this patch on the bug tracker and no one really cared about it and then posting it here only on someones advice and it was still not reviewed or integrated.
And I can't imagine that it is all my fault.
</pre>
</blockquote>
<p>On April 5th, 2013, 7:01 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you should download it with git, and send the patch against master branch, see http://techbase.kde.org/Getting_Started and http://www.youtube.com/watch?v=cqnNVmJocR4</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm discarding this review, you gave a ship it to yourself and that was wrong. I gave you the pointers on how to do it right, i'm sorry if you find it hard.</pre>
<br />
<p>- Albert</p>
<br />
<p>On January 10th, 2013, 3:18 p.m. UTC, Leszek Lesner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Leszek Lesner.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the LastNotificationsPopup moving around when clicking on a button and adds a move button to freely place it all over the desktop.
Also this removes notifications jobs from the notification icon. (So clicking on X does not hide but really closes the notification and removes it)
Also this fixes layout problems with 3 buttons displayed inside a notification (this caused the X button to overlap with the upper actionbutton).
As my original diff was not recognized as normal diff(don't know what I did wrong there) I attached the patch directly to this thread. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdialog --passivepopup "bla"
click on X, closes and removes job from notification Icon
click and hold on move button moves the popup freely on the screen. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311413">311413</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108325/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff">Patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>