<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111263/">http://git.reviewboard.kde.org/r/111263/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work!
After fixing mentioned minor issues, ship it!
Also try to give whitespace before and after '=' operator for clarity.
We will discuss issue related to showing places on email/IRC.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111263/diff/3/?file=166161#file166161line57" style="color: black; font-weight: bold; text-decoration: underline;">browsingbackends/localfiles/localfilesabstractbackend.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QModelIndex</span> <span class="n">m_index</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_index variable is not being used in multiple functions. So, make it local to expand()</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111263/diff/3/?file=166162#file166162line26" style="color: black; font-weight: bold; text-decoration: underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <mediacenter/mediacenter.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not required here</pre>
</div>
<br />
<p>- Sinny</p>
<br />
<p>On June 27th, 2013, 5 p.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.</div>
<div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 5 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The File explorer/browser in the plasma-mediacenter has been revamped. The side-panel has been removed. Now the drives and other system directories appears on clicking "Browse Pics/Music/Videos" instead of "home" folder contents appeaaring earlier after selecting this particular option. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Major things working fine , but there might be certain issues regarding the correct folder contents shown inside any folder in any particular directory.
Further malformed url might appear on clicking certain drives. However this can be fixed later :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractmodel.h <span style="color: grey">(c4c8be3)</span></li>
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: grey">(5768fb3)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: grey">(6c66b43)</span></li>
<li>browsingbackends/localfiles/localmusic/CMakeLists.txt <span style="color: grey">(4b804ae)</span></li>
<li>browsingbackends/localfiles/localpictures/CMakeLists.txt <span style="color: grey">(c7ba5fa)</span></li>
<li>browsingbackends/localfiles/localplacesmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localplacesmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localvideos/CMakeLists.txt <span style="color: grey">(15677d7)</span></li>
<li>browsingbackends/localfiles/localfilesabstractbackend.h <span style="color: grey">(b7cc909)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>