<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110453/">http://git.reviewboard.kde.org/r/110453/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 15th, 2013, 5:36 p.m. UTC, <b>José Millán Soto</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm aware that a new version of the tasks applet is being done in QML, but most of the changes are done in the library and not in the applet itself (the only change made to the applet is to add the ordering in the "Order by" combobox of the config dialog), so I think this patch can be applied even if the tasks applet is going to be replaced.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The QML version does indeed still rely on the sorting strategies implemented in the library, so this patch is fairly low-impact as far as the QML port is concerned.</pre>
<br />
<p>- Eike</p>
<br />
<p>On May 15th, 2013, 5:34 p.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 5:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A new ordering strategy ActivitySortingStrategy was created. This strategy will
order elements by the activities they are available on.
The ones which are available in the activities with more tasks will be
displayed first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Three activities were created (called Activity 1, 2 and 3), and several dialogs were created (the activities to which each dialog were assigned are marked by the numbers after the "A" in the title).
Screenshot 1 shows the task manager running in plasma-windowed with grouping disabled, and the task manager being assigned to all activities. The second screenshot shows the task manager if the task manager is assigned only to Activity 1, an instance of xmessage is assigned to activity 2 and the grouping by program is active.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(375a0d6)</span></li>
<li>libs/taskmanager/groupmanager.h <span style="color: grey">(f7e9878)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: grey">(45c15a9)</span></li>
<li>libs/taskmanager/strategies/activitysortingstrategy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/strategies/activitysortingstrategy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/tasks/tasks.cpp <span style="color: grey">(0a86dcf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110453/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img1.png">Screenshot 1</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img2.png">Screenshot 2</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>