<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109965/">http://git.reviewboard.kde.org/r/109965/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On May 12th, 2013, 8:59 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 12, 2013, 8:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch
* removes the duplicated code in assetimporters
* adds asset's size into the db
* and fixes a few small issues</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't noticed regression.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>assetimporters/CMakeLists.txt <span style="color: grey">(24e76a0)</span></li>
<li>assetimporters/database-common/channelscatalog.h <span style="color: grey">(5d39c02)</span></li>
<li>assetimporters/database-common/channelscatalog.cpp <span style="color: grey">(6ca0aef)</span></li>
<li>assetimporters/database-common/database.h <span style="color: grey">(9883216)</span></li>
<li>assetimporters/database-common/database.cpp <span style="color: grey">(e860bdd)</span></li>
<li>assetimporters/kdeartwork-wallpapers/CMakeLists.txt <span style="color: grey">(56d19b9)</span></li>
<li>assetimporters/kdeartwork-wallpapers/database.h <span style="color: grey">(6991758)</span></li>
<li>assetimporters/kdeartwork-wallpapers/database.cpp <span style="color: grey">(d75cdda)</span></li>
<li>assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/kdeartwork-wallpapers/main.cpp <span style="color: grey">(708a949)</span></li>
<li>assetimporters/obs/CMakeLists.txt <span style="color: grey">(2dbcd42)</span></li>
<li>assetimporters/obs/channelscatalog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/obs/channelscatalog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/obs/packagedatabase.h <span style="color: grey">(99f4e17)</span></li>
<li>assetimporters/obs/packagedatabase.cpp <span style="color: grey">(ae43b8e)</span></li>
<li>assetimporters/projectgutenberg/CMakeLists.txt <span style="color: grey">(b86cc49)</span></li>
<li>assetimporters/projectgutenberg/src/CMakeLists.txt <span style="color: grey">(2d48e9c)</span></li>
<li>assetimporters/projectgutenberg/src/database.h <span style="color: grey">(8dba0ba)</span></li>
<li>assetimporters/projectgutenberg/src/database.cpp <span style="color: grey">(75cba69)</span></li>
<li>assetimporters/projectgutenberg/src/gutenbergdatabase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/projectgutenberg/src/gutenbergdatabase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>assetimporters/projectgutenberg/src/main.cpp <span style="color: grey">(46f2340)</span></li>
<li>sql/bodega.sql <span style="color: grey">(44f8641)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>