<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110122/">http://git.reviewboard.kde.org/r/110122/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 25th, 2013, 2:02 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line52" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">lastNotificationTimer</span><span class="p">.</span><span class="nx">interval</span> <span class="o">=</span> <span class="nb"><span class="hl">Math</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">max</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">4000</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="nb"><span class="hl">Math</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">min</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">60</span></span><span class="o"><span class="hl">*</span></span><span class="mi"><span class="hl">1000</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="nx">notification<span class="hl">sModel</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">get</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">)</span>.</span><span class="nx">expireTimeout</span><span class="p"><span class="hl">))</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">lastNotificationTimer</span><span class="p">.</span><span class="nx">interval</span> <span class="o">=</span> <span class="nx">notification</span><span class="p">.</span><span class="nx">expireTimeout</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied.</pre>
</blockquote>
<p>On April 25th, 2013, 2:09 p.m. UTC, <b>James Pike</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The minimum is set on line 45.</pre>
</blockquote>
<p>On April 25th, 2013, 2:12 p.m. UTC, <b>James Pike</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did however remove the 60 second maximum as I believe this is too low, many people in my office have expressed a desire for higher notification timeouts. I mark notifications from my boss with a timeout of several thousand seconds to ensure I never miss them. Else he'll get angry.</pre>
</blockquote>
<p>On April 25th, 2013, 2:20 p.m. UTC, <b>James Pike</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please feel free to re-instate the 60 second maximum though, it just means I'll never be able to use KDE and have a non-angry boss at the same time :P</pre>
</blockquote>
<p>On April 26th, 2013, 2:07 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If an information is so important that you must not miss it, it should not be displayed as a notification (or at least not only). Notifications should only be used for information that may be interesting, but not critical.
If you have to set timeouts to basically "forever", that's a sign that you're using a notification for the wrong purpose.</pre>
</blockquote>
<p>On April 26th, 2013, 10:55 p.m. UTC, <b>James Pike</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And sure, I have audio notifications on top. Yet I still think, it's not up to you to decide purpose, to decide the notification period. To decide on behalf of everyone else. I didn't think that was the KDE philosophy at all, I thought the philosophy was on user configuration. So IMO to decide on a blanket 60 second maximum for everyone and enforce that is wrong.
Do you really wanna be the kinda person who tells an entire community about what purpose "should be"?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Essentially I'm asking, why do you feel you have a mandate, as a WM, to override hints given by user applications? Why do you assume a user application cannot have a timeout above 60 seconds? Way too authoritarian for my likings...</pre>
<br />
<p>- James</p>
<br />
<p>On April 25th, 2013, 1:58 p.m. UTC, James Pike wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By James Pike.</div>
<p style="color: grey;"><i>Updated April 25, 2013, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout.
This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test script in https://bugs.kde.org/show_bug.cgi?id=318295</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318295">318295</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span style="color: grey">(2fa1b11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110122/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>