<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109821/">http://git.reviewboard.kde.org/r/109821/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c32a502181dbbacc34e8144b6253b62ff1598d88 by Giorgos Tsiapaliokas to branch terietor/savesystem/APIv2.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 2nd, 2013, 6:24 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 2, 2013, 6:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements a proper KJob and uses the job as an async when
and where it makes sense.
My opinion about the patch(feel free to ignore it:)
I tried to make all the jobs async but in some cases it was an overhead
and the code was looking bad, so I implemented the execSynchrousnly in order
to emphasize that the job is sync and to have a better result.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't found any regressions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/savesystem/timeline.cpp <span style="color: grey">(4293dae)</span></li>
<li>plasmate/savesystem/timeline.h <span style="color: grey">(95e7e97)</span></li>
<li>plasmate/savesystem/gitrunner.cpp <span style="color: grey">(7520239)</span></li>
<li>plasmate/savesystem/gitrunner.h <span style="color: grey">(dfacc5b)</span></li>
<li>plasmate/savesystem/dvcsjob.cpp <span style="color: grey">(6f83307)</span></li>
<li>plasmate/savesystem/dvcsjob.h <span style="color: grey">(38df371)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109821/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>