<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109825/">http://git.reviewboard.kde.org/r/109825/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 5th, 2013, 4:48 p.m. UTC, <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109825/diff/2/?file=131464#file131464line291" style="color: black; font-weight: bold; text-decoration: underline;">resources/facebook/facebookresource_notifications.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">291</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//</span><span class="cs">TODO</span><span class="c1">: sync notifications collection? needs fetching collection by remote id</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is this something you haven't gotten around to do yet or something you are not sure how to do it?</pre>
</blockquote>
<p>On April 8th, 2013, 11:04 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure how to do it - get a collection if I know only the remote id. Suggestions?</pre>
</blockquote>
<p>On April 8th, 2013, 12:44 p.m. UTC, <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A resource can address its own collections and items just by specifying the remoteId, So just use a CollectionFetchJob with a collection object that has proper remoteId</pre>
</blockquote>
<p>On April 8th, 2013, 1:03 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice, will give it a try</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So this
Collection notifications;
notifications.setRemoteId(QLatin1String("notifications"));
CollectionFetchJob *collectionJob = new CollectionFetchJob(notifications, CollectionFetchJob::FirstLevel, this);
connect(collectionJob, SIGNAL(collectionsReceived(Akonadi::Collection::List)),
this, SLOT(notificationCollectionFetched(Akonadi::Collection::List)));
should just work right? It seems to never reach the slot :/</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 5th, 2013, 4:01 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 5, 2013, 4:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch displays a KNotification whenever an unread notification exists on Facebook. This KNotification groups at most 3 notifications into one popup and then say "...and N more" if there is more. It also keeps track of which notifications were already displayed and does not display them again unless they were updated on the server. This is all stored in a separate config file.
Then it creates a KSNI for the notifications where it always show the newest three notifications in the tooltip (regardless if it was displayed before or not) and creates a menu with the notifications, which opens browser with the notification link.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>resources/facebook/CMakeLists.txt <span style="color: grey">(e8c6381)</span></li>
<li>resources/facebook/facebookresource.h <span style="color: grey">(4a16c0c)</span></li>
<li>resources/facebook/facebookresource.cpp <span style="color: grey">(67e8f3b)</span></li>
<li>resources/facebook/facebookresource_notifications.cpp <span style="color: grey">(7f6b8c4)</span></li>
<li>resources/facebook/serializer/akonadi_serializer_socialnotification.cpp <span style="color: grey">(a261e14)</span></li>
<li>resources/facebook/settingsbase.kcfg <span style="color: grey">(9f8e4b5)</span></li>
<li>resources/facebook/settingsdialog.cpp <span style="color: grey">(bfb7826)</span></li>
<li>resources/facebook/settingsdialog.ui <span style="color: grey">(68b6a24)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109825/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/facebook_notifications.png">KSNI</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>