<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109500/">http://git.reviewboard.kde.org/r/109500/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking at the code, it seems apparent that DvcsJob could use some re-factoring as well. It is a KJob .. but it doesn't behave like one at all, nor is it used like one. Either it should be made a properly async KJob, or if that is neither needed nor desired then it should probably not subclass from KJob. Note that it is usually new'd and then deleted all within the same method (or methods it calls) which says to me that it isn't async right now and probably should just be created on the stack and passed around ..
This is something for a different patch set of course :)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On March 20th, 2013, 6:16 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated March 20, 2013, 6:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,
this patch is the refactor of the savesystem.
Also in this refactor the above bugs are being fixed.
Q: Why do we need a refactor?
A: * Before this patch in order to take the git log we did
some parsing, which wasn't nice. With this patch we use git log --pretty-format.
* There are some other changes like coding style stuff and striping \n from strings.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316202">316202</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316724">316724</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316725">316725</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/savesystem/dvcsjob.cpp <span style="color: grey">(288d7a6)</span></li>
<li>plasmate/savesystem/gitrunner.h <span style="color: grey">(50f87ab)</span></li>
<li>plasmate/savesystem/gitrunner.cpp <span style="color: grey">(b263be6)</span></li>
<li>plasmate/savesystem/timeline.h <span style="color: grey">(73849d0)</span></li>
<li>plasmate/savesystem/timeline.cpp <span style="color: grey">(231fc46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109500/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>