<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109606/">http://git.reviewboard.kde.org/r/109606/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Alex Merry.</div>
<div>By Hrvoje Senjan.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes possible for plasma themes to have a custom nocover, until now, the QML re-written version always had it hardcoded within the plasmoid.
With the patch, the nocover goes to ~desktoptheme/default/widgets, and that way it is always default, unless a plasma theme provides another svg.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using any theme that doesn't have the svg, makes the plasmoid uses the default one. Changed theme that *does* have another nocover, it changes correctly to that one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/nowplaying/CMakeLists.txt <span style="color: grey">(4a1ff12)</span></li>
<li>applets/nowplaying/nocover.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/nowplaying/package/contents/images/nocover.svgz <span style="color: grey">(67e8c28c2aecc23621ea057cdc57ac4d04a660ea)</span></li>
<li>applets/nowplaying/package/contents/ui/AlbumArt.qml <span style="color: grey">(7c70b0f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109606/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>