<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109528/">http://git.reviewboard.kde.org/r/109528/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 683eac4e304d7c07477c80533044b17ad2f2734e by Giorgos Tsiapaliokas to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 16th, 2013, 8:29 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated March 16, 2013, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports the bodega-server into the new node-postgres API,
this output which comes from the node-postgres module contains more
info about the new API
WARNING!!
pg.connect(function(err, client) { ...}) is deprecated and will be removed it v1.0.0 (very soon)
instead, use pg.connect(function(err, client, done) { ... })
automatic releasing of clients back to the pool was a mistake and will be removed
please see the following for more details:
https://github.com/brianc/node-postgres/wiki/pg
https://github.com/brianc/node-postgres/issues/227
https://github.com/brianc/node-postgres/pull/274
feel free to get in touch via github if you have questions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/lib/bodegadb.js <span style="color: grey">(d17a77e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109528/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>