<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109444/">http://git.reviewboard.kde.org/r/109444/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109444/diff/2/?file=119347#file119347line49" style="color: black; font-weight: bold; text-decoration: underline;">src/plasma/private/theme_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">class</span> <span class="nc">ThemePrivateSingleton</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">err, that shouldn't be there in the current implementation (was an early alternative approach)</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On March 11th, 2013, 9:40 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 9:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this makes ThemePrivate shared, so Theme instances can be created without relying on it to be a singleton.
as is right now, by default a single "global" theme will be used.
if instead a theme instance is created with a name as a parameter, that instance will be independent.
useGlobalSettings should continue to decide where the configuration will be saved in plasmarc (config group as a property still to be implemented)
The theme writing the config on the global or independent place is something actually independent from the "independent" instance of theme called with new Theme(themeName), so code may be made effectively simpler if that ctor is removed (and with that the themes hash in ThemePrivate): but this would also mean we will not ever try to have two themes in the same process (which may be a good thing, just have to be a decision.)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/theme.h <span style="color: grey">(4a28c74)</span></li>
<li>src/plasma/theme.cpp <span style="color: grey">(618d019)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(a75d31c)</span></li>
<li>src/plasma/private/theme_p.h <span style="color: grey">(e8b5250)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109444/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>