<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108969/">http://git.reviewboard.kde.org/r/108969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2013, 10:36 p.m. SAST, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe to slightly reduce controls size? This made controls gigantic here. Otherwise, great improvement :-)</pre>
</blockquote>
<p>On February 18th, 2013, 8:50 p.m. SAST, <b>Tjaart Blignaut</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you post a screen shot. I changed the icon sizing policy but in general the idea was to make the controls larger. You can check the latest diff to see if it solves the problem for you.</pre>
</blockquote>
<p>On February 18th, 2013, 8:57 p.m. SAST, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure. http://i.imgur.com/xhr1EDA.png
This is with diff3</pre>
</blockquote>
<p>On February 18th, 2013, 9:18 p.m. SAST, <b>Tjaart Blignaut</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You don't like this control size? It was intended to be this large because relative to everything else the controls were quite small. 22x22 probably. Now they are 32x32? Is there any specific policy with regards to size that should be followed? I also noticed that the controls are the only thing that is different in your case, and not the font sizes which are also modified?</pre>
</blockquote>
<p>On February 18th, 2013, 10 p.m. SAST, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, as said, i find them a bit huge :-)
Yes, text appears to be the same as it was before, but i don't see you touching size of it in the diff? Also, no bold here, and in the patch.
Maybe not the patch you wanted to push?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay I think I fixed the diff. I messed it up due to my confusing workflow. See if you agree that tiny icons will not fit with the larger fonts?</pre>
<br />
<p>- Tjaart</p>
<br />
<p>On February 18th, 2013, 10:18 p.m. SAST, Tjaart Blignaut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Tjaart Blignaut.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2013, 10:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch
- allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the "by" and "on" text
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/nowplaying/package/contents/ui/Controls.qml <span style="color: grey">(382ccf6)</span></li>
<li>applets/nowplaying/package/contents/ui/FullLayout.qml <span style="color: grey">(c92f5c6)</span></li>
<li>applets/nowplaying/package/contents/ui/MetadataPanel.qml <span style="color: grey">(dc01be6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108969/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png">Before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png">After</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png">With play controls</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>