<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108798/">http://git.reviewboard.kde.org/r/108798/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, all the camel case headers need to be converted so it can build in-framework now. (previously all this code was build in other repos after kdelibs, soooo.. :)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On February 6th, 2013, 5:56 a.m. UTC, Shawn Starr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Shawn Starr.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2013, 5:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Trying to build plasma-framework I encountered some headers using 3rd party names vs internal and I believe these should all be internal headers? Fixing those and commenting out one of the testcase apps gets it to build. Although there's other issues with not linking kdecore/ui etc properly. Given this code is in heavy development, you may disregard this review request but I'd still like to go though the process.
btw, I'm back ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Able to build things, but didn't look into why proper KDE libraries not being linked in yet (editing the generated CMakefiles/component.dir/link.txt works around this for now)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>scriptengines/qml/common/scriptenv.cpp <span style="color: grey">(b79cd3d)</span></li>
<li>declarativeimports/core/framesvgitem.h <span style="color: grey">(fb4741a)</span></li>
<li>scriptengines/qml/declarative/packageaccessmanager.h <span style="color: grey">(3e9a712)</span></li>
<li>scriptengines/qml/declarative/packageaccessmanagerfactory.h <span style="color: grey">(70e4eb9)</span></li>
<li>scriptengines/qml/plasmoid/abstractjsappletscript.h <span style="color: grey">(cdd709c)</span></li>
<li>scriptengines/qml/plasmoid/appletauthorization.cpp <span style="color: grey">(6fe9454)</span></li>
<li>scriptengines/qml/plasmoid/appletinterface.h <span style="color: grey">(6226802)</span></li>
<li>scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: grey">(f5dc187)</span></li>
<li>scriptengines/qml/plasmoid/declarativeappletscript.h <span style="color: grey">(18b324b)</span></li>
<li>scriptengines/qml/plasmoid/declarativeappletscript.cpp <span style="color: grey">(75d25eb)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(ecbfad9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108798/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>