<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108438/">http://git.reviewboard.kde.org/r/108438/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, and Xuetian Weng.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2013, 2:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added checks in PW and DG</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use translucent/dialogs/background elements where possible
In effects it's obvious that compositing is enabled, so specifying the
translucent element is no problem.
In tabbox a context property "compositing" is injected which decides
whether "translucent" or "opaque" elements should be used. Here the
translucent elements are only used if the Blur effect is available - for
this a new Effect::Feature Blur is introduced and in addition it is
tested whether the theme provides the translucent element.
Also the masking is adjusted to ensure that only the shadow is not
blurred.
Reason for this change is that Plasma theme seems not always to pick up
whether compositing is used when used from inside KWin. It does not cover
the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot
(yet) inject that we use compositing.
Overall I'm quite unhappy with this patch and I do hope we can fix it in
the proper place in the lifetime of 4.10 and revert this patch.
CCBUG: 311995
REVIEW: 108438</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* XRender -> opaque element
* OpenGL with blur -> translucent element
* non-default theme -> normal element</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur.h <span style="color: grey">(a3820856a8db49b805ddbb2a319b8f7609dcba81)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: grey">(53532ccff72d2a1f303265a898fd7b1fc7ea35a6)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: grey">(ff53aefea1b2722aea7f6c47b345c6d78e855339)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: grey">(6aea85d20772a8a69855b81ef687b91dc93b98ac)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(b4d615178a0e0b8b633626a1813dfa7065515b97)</span></li>
<li>kwin/tabbox/qml/CMakeLists.txt <span style="color: grey">(bda7d8b95ed3b4fb4093c9960f940a0d678710f8)</span></li>
<li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: grey">(87de733bf0fa1ad19d4d9203de6c6fc3548ff57f)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: grey">(4a3666d2befe0010f7d9b7d4414853e8c92a92a1)</span></li>
<li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: grey">(2bf04a50cfc8540efbc86d64bf1f6de28e63d230)</span></li>
<li>kwin/tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: grey">(5e3f9a6f2ad76e7eeb7ee1e51d42e0c891b762ec)</span></li>
<li>kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: grey">(e539c8970acff701b92bdaaf816a40ccba94e4b8)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: grey">(0c9b4f7f7df52f8a629d0c847185db38aa9f2c26)</span></li>
<li>kwin/tabbox/qml/clients/text/contents/ui/main.qml <span style="color: grey">(ccae17d96b231269a7d8ec0ecc20b0ee69453d09)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: grey">(4c33703d54c84fd54da94f821234e4cbd9c1c001)</span></li>
<li>kwin/tabbox/qml/desktop.qml <span style="color: grey">(e8203b6004a321fcc5ae6d10347fdbb7144662a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108438/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>