<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108585/">http://git.reviewboard.kde.org/r/108585/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 26th, 2013, 2:03 p.m. UTC, <b>Oliver Henshaw</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't have multiple monitors to test with, but can you test with the the LockWindow set to some colour other than black? Just so that any bizarre side effects are more obvious.</pre>
</blockquote>
<p>On January 26th, 2013, 3:35 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What "bizarre side effects" would you expect?
My screens are ok ;-P
(I could see the clock from the WM on where the exposed area would have been and that area was now black)
I'll try by a nice dodgerblue nevertheless.</pre>
</blockquote>
<p>On January 26th, 2013, 4:02 p.m. UTC, <b>Oliver Henshaw</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wanted to be completely sure that it is the lockwindow that is covering the screen and not some other component. Perhaps that's overly paranoid, but I suppose we should err towards the paranoid.</pre>
</blockquote>
<p>On January 26th, 2013, 4:32 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turns nicely blue, i also debugged me the geometry and that the slot is caught (twice for the screecount change AND the resize)
Btw and while at it - the code is partially a bit "weird":
QPalette p = palette();
p.setColor(backgroundRole(), Qt::transparent); // this is what you got to turn blue
** Q: wtf is the background color "transparent" - this is black for 24bit, but guess what it is on a 32 drawable (hint: it's not pink)
--> Reason?
setPalette(p); // good
setAttribute(Qt::WA_PaintOnScreen, true); // bypasses doublebuffer, saves RAM - good
setAttribute(Qt::WA_NoSystemBackground, false); // iirc default, but good
setAttribute(Qt::WA_PaintOutsidePaintEvent, true); // for bitBlt in resume()
** Q: what ::resume() and what bitBlt? - bitBlt is afair not evel legally supported since Qt 4 and "grep -r resume *" in the screenlocker path is this lone and a label content.
void LockWindow::paintEvent(QPaintEvent* )
{
QPainter p(this);
p.setBrush(Qt::black); // set only this to Qt::blue, attempt a resize (no matter on how many screens) and watch the result
p.drawRect(geometry());
}
** Q: "why"? - everything on top says "no paint events", so why is paintevent implemented at all (it will for other reasons once shadow the contents)
** Q: p.setPen(Qt::black)?
Does anybody know about the legacy of this?
Some Qt3 port that requires cleanup or is this to work-a-round special system issues?
Quite some of it also is only supported on X11, not Windows or MacOS and i'm not sure about Wayland and Symbian.
To test this, one btw. does not necessarily require a multiscreen setup - it's sufficient to "xrandr -s 1024x768", lock screen, VT1, export DISPLAY=:0; xrandr -s 0 and "sleep 5; pkill kscreenlocker_g" (or so) -> VT7, see lockwindow</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">suspend()/resume() seem to have been methods in the 4.9 krunner/lock to stop/start the 4.9 screensaver if e.g. it couldn't be seen.
The bitBlt comment was introduced in commit 71b8c4e239d1b9f7f4884d75afefda794e011034; the bitBlt use in resume() was removed/replaced in commit 2a23308ce7fb6f5918b3f7c25ed3b2a70cbcc0e7.</pre>
<br />
<p>- Oliver</p>
<br />
<p>On January 25th, 2013, 11:04 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 11:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually was wrong, we do get the signals from QDesktopWidget - so the fix is pretty trivial ;-)
Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on it (which has a translucent background when compositing is active and relies on the lockwindow to cover the screen)
I've not checked such screen"saver" and have to admit, i'd not even know where to check for the sources.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">recompiled _all_ ksmserver, logged out, in, locked the screen, updated the screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), killed the gretter (noticed that i could have simply xrandr'd the geometry from VT1 as well - "blast!")
everything is nicely black (with compositing)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313835">313835</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/lockwindow.h <span style="color: grey">(5cbc769)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: grey">(147853b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108585/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>