<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108453/">http://git.reviewboard.kde.org/r/108453/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks nice (just some small nitpicks in the ui)
as procedure, now it should be in integration for a while(Aaron, can you do it?)
, tested, and hopefully merged in few days
also, the applet should be in the default setup by changing the default plasma-device-appetsrc in the plasma-mobile-config repo
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108453/diff/1/?file=107613#file107613line21" style="color: black; font-weight: bold; text-decoration: underline;">applets/orientation/contents/code/Orientation.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kr">import</span> <span class="nx">Qt</span> <span class="mf">4.7</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">importQtQuick 1.1 instead of Qt 4.7</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108453/diff/1/?file=107613#file107613line29" style="color: black; font-weight: bold; text-decoration: underline;">applets/orientation/contents/code/Orientation.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">property</span> <span class="kr">int</span> <span class="k">minimumWidth:</span> <span class="nx">buttonColumn</span><span class="p">.</span><span class="nx">width</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if the default width seems to be too big, try to give it preferredWidth or maximumwidth as well</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108453/diff/1/?file=107613#file107613line46" style="color: black; font-weight: bold; text-decoration: underline;">applets/orientation/contents/code/Orientation.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">width:</span> <span class="mi">32</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use theme.mediumIconSize instead of 32</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On January 17th, 2013, 8:31 p.m. UTC, Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2013, 8:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds an orientation dataengine to plasma which reacts to qt sensors and also takes commands via the orientation applet to rotate left or right. Rotation rotates both the touch screen device via xinput calls and the x screen via libkscreen.
TODO: Add a lock/unlock to the applet once qt sensors are providing input.
also, I'm not sure why the orientation applet expansion is so wide, it really only needs to accomodate those two icons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7d030f0bd962225b9787bb8a1ff8037dd21a0b3c)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(f33ba4066b32df625ac143698d5e546ca302e523)</span></li>
<li>applets/orientation/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/orientation/contents/code/Orientation.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/orientation/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindQtMobility.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: grey">(c9bfa9358bd6eeb3773b811c46a043305abd60f7)</span></li>
<li>dataengines/orientation/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientation.operations <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationengine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationservice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/orientationservice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/orientation/plasma-engine-orientation.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/contour-tablet-homescreen/contents/config/plasma-default-layoutrc <span style="color: grey">(98d9b7316eb543a172b49ae4cb8110c87d189a56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>