<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108375/">http://git.reviewboard.kde.org/r/108375/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 17053ae6ec7dd9435b944e6a4f2ad435a91df269 by Thomas Lübking to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 13th, 2013, 9:32 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2013, 9:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. Redirecting to plasma.
The patch fixes:
a) setting the properties
... to happen on show, this is required because the "hide()" will (usually and in this case) destroy the drawable ("window") and with it all properties on the server; so they need to be re/set "when required".
b) input processing
Relevant events are sucked so that we don't receive them more than once (usually i'd discourage from installing an eventfilter on the application but the screenlocker is ideally of low event occurrance anyway)
c) triggering events
Not really a fix but the "saver" is now hidden on any keyPress and only reshown on escape keyRelease (iirc this was the behavior of most screenSavers when i used them because there was no dpms ...)
d) screen geometry adaptation
if the user attaches a screen and that auto-extends the desktop, the screenlocker currently yells a warning and happily exposes the desktop (there's still a problem in case KWin fades in the locker but that's not matter to this patch)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Screensaver" - Emulation ;-)
m_showScreenSaver = true;
// screensaverWindow->setBackground(backgroundPix);
screensaverWindow->setAutoFillBackground(true);</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311116">311116</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeter.cpp <span style="color: grey">(f5918f9)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: grey">(6b2c263)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(a35c8ae)</span></li>
<li>ksmserver/screenlocker/greeter/screensaverwindow.cpp <span style="color: grey">(adb2587)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108375/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>