<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108284/">http://git.reviewboard.kde.org/r/108284/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">like the idea</pre>
<br />
<p>- Marco</p>
<br />
<p>On January 9th, 2013, 4:22 a.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 4:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> plasmoidviewer: respect --containment flag in sizing and scenerect
The normal behavior of plasmoidviewer, which resizes the applet to the
window, is not very useful for testing containments, at it sets the
scenerect and resizes the widget where it is really the containment's
job to take care of the layout.
So, when the --containment flag is set, and a plugin is found:
- do not change the scenerect anymore
- do not resize the widget
- do not wire up applet resize events to our view's scenerect
- set window title to $Applet: $Containment
- change icon to containment's icon
This set of changes makes plasmoidviewer really useful, where it
previously would often flick out of the view and show all kinds of
applet placement madness when used with the --containment flag.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested with and without containments. Without --containment, behavior is unaffected initially and when resizing, with --containment, behavior matches expectations: i.e. the applet is under the containment's layout control.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/fullview.h <span style="color: grey">(eed247f)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(109af6c)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(1802982)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>