<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108241/">http://git.reviewboard.kde.org/r/108241/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2013, 4:49 p.m., <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog use hardcoded dialogs/background svg path internally, which should be tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog paintEvent. I think you should copy kdelibs/plasma/private/dialogshadows.{h,cpp} here, and check how kdelibs handle use this, instead of use Plasma::Dialog here.</pre>
</blockquote>
<p>On January 7th, 2013, 9:05 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">paintEvent doesn't matter, but the Dialog does indeed use the dialogs/background.svg and that is important as Xuetian has pointed out. so yes, some sort of duplication will be necessary to fix this in the near-term. :/
the proper long term solution is to make it use Plasma::Tooltip. no excuses. no "but i want it to ..." BS.
when i have suggested in the past to not have custom tooltips but extend the libplasma ones until they do what is needed and then use those, people have just done their own thing anyways. if they had listened this problem would never have existed. it pisses me off to no end that we end up with such problems just because people think they know better and ignore good advice.</pre>
</blockquote>
<p>On January 8th, 2013, 8:52 a.m., <b>Cedric Bellegarde</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>the proper long term solution is to make it use Plasma::Tooltip
Plasma::Tooltip is private, no ?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">icontasks seems to use a fork of Plasma::Tooltip, but don't know why it do not get shadows, will try to check for diffs</pre>
<br />
<p>- Cedric</p>
<br />
<p>On January 7th, 2013, 1:53 p.m., Cedric Bellegarde wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Cedric Bellegarde.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 1:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for icontasks tooltips</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">localily tested, no problem</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/tooltips/tooltip.cpp <span style="color: grey">(43f09ed)</span></li>
<li>applets/icontasks/tooltips/tooltip_p.h <span style="color: grey">(2b8ad0c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108241/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>