<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107881/">http://git.reviewboard.kde.org/r/107881/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2013, 10:49 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i can understand changing the visible name, but why change the plugin name and the rest of it? that's an implementation detail, and while the name used may be technically "wrong" it is both a smaller change as well as a safer change to leave them as-is. each kconfig update script is something that needs to be processed at runtime, which must be present to provide an upgrade path, etc.
so imo only the user visible strings should be altered and the reset should remain as-is.</pre>
</blockquote>
<p>On January 7th, 2013, 2:43 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can see your concern of upgrading (especially for those who compile and install KDE manually instead of using package manager (like emerge) to ensure clean removal of previously installed files). Maybe one dummy konsolesessions.desktop (only containing Hidden=True) should also be installed to avoid users seeing both "konsole profiles" and "konsole sessions" in krunner.
But the reason I want to also change the reset is not for users, but for developers/contributors, especially for those (including myself) who are not familiar with the history of those runners and just want to investigate and fix some bug quickly from time to time.
If I just change the user visible name, then there will be a konsoleseesions/ subfolder providing krunner_konsolesessions.so and konsolesessions.desktop, yet its visual name is "konsole profiles" , and its entry within krunnerrc is "konsolesessionsEnabled", and what it does is "konsole profiles". That is just confusing(even more than now) to random contributors. Unless someone digs the code, commit history and this review request, he/she can hardly understand why he/she is seeing such a strange combination. That even does not take into account all those names styled after "sessions" instead of "profiles" within the existing code.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">moving the directory in the source tree from konsolesessions to konsole is fine for me. the rest should not be touched. the rare case of developer confusion on a rarely touched component, which can be resolved with a few minutes effort, does not come even close to the cost of making changes that affect every user install out there.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 31st, 2012, 6:58 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions.
Also, the equivalent plasmoid is properly named as "konsole profiles". </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: grey">(bb4b491)</span></li>
<li>runners/konsoleprofiles/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsolesessions/CMakeLists.txt <span style="color: grey">(c1d5cea)</span></li>
<li>runners/konsolesessions/Messages.sh <span style="color: grey">(5f03904)</span></li>
<li>runners/konsolesessions/konsolesessions.cpp <span style="color: grey">(ed7550a)</span></li>
<li>runners/konsolesessions/konsolesessions.desktop <span style="color: grey">(7d9ce5a)</span></li>
<li>runners/konsolesessions/konsolesessions.h <span style="color: grey">(a98c253)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107881/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>