<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108241/">http://git.reviewboard.kde.org/r/108241/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog use hardcoded dialogs/background svg path internally, which should be tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog paintEvent. I think you should copy kdelibs/plasma/private/dialogshadows.{h,cpp} here, and check how kdelibs handle use this, instead of use Plasma::Dialog here.</pre>
<br />
<p>- Xuetian</p>
<br />
<p>On January 7th, 2013, 1:53 p.m., Cedric Bellegarde wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Cedric Bellegarde.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 1:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for icontasks tooltips</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">localily tested, no problem</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/tooltips/tooltip.cpp <span style="color: grey">(43f09ed)</span></li>
<li>applets/icontasks/tooltips/tooltip_p.h <span style="color: grey">(2b8ad0c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108241/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>