<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107600/">http://git.reviewboard.kde.org/r/107600/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2012, 4:32 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as this is indeed a rather widely shifting style (far beyond KDE), as long as it is consistent with kdelibs and Qt i'm ok with this. and consistency is the hard bit. yes, there is 107678 for kdelibs (which is half the battle) but that leaves Qt. if your patch makes it into qt (4 or 5) then i'll put my ShipIt! on this and 107678 ...
given that we face this same issue in krunner, i'd like to see the change made ... i'm just very unhappy about having different behaviours between the "same" Qt and KDE widgets.</pre>
</blockquote>
<p>On December 14th, 2012, 3:44 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense. I am planning on providing a patch for Qt anyway. In the long run we should even be able to replace KLineEdit::clickMessage implementation to QLineEdit::placeHolder.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"In the long run we should even be able to replace KLineEdit::clickMessage implementation to QLineEdit::placeHolder."
that would really be the best thing :)
(and given we can now submit changes to Qt, i hope that in future we'll create far fewer of these kinds of KDE-specific features)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 12th, 2012, 5:11 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2012, 5:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch keeps the place holder text visible when a TextField is focused. This is useful for situations where a text field is focused at startup. We use it in Homerun for the search field.
I filed a similar review-request for kdelibs KLineEdit and KTextEdit: https://git.reviewboard.kde.org/r/107678/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran widgetgallery with the patch code, as can be seen in attached screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: grey">(d19e7d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107600/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107600/s/872/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/05/qml-textfield-placeholder_400x100.png" style="border: 1px black solid;" alt="TextField with placeholder from Widget Gallery" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>