<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107868/">http://git.reviewboard.kde.org/r/107868/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how about instead of having 2 plugins, just add sessions support to this one plugin? it can search both profiles *and* sessions and show all that match. it can note which it is, perhaps, in the data() of the match so that run() can do the right thing. that will mean 1 less plugin, 1 less kconf update script, 1 less translation file, etc. for the same functionality.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 31st, 2012, 7:12 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 7:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror.
The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188494">188494</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: grey">(bb4b491)</span></li>
<li>runners/konquerorprofiles/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorprofiles.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konquerorsessions/CMakeLists.txt <span style="color: grey">(be2ea9d)</span></li>
<li>runners/konquerorsessions/Messages.sh <span style="color: grey">(0720e1e)</span></li>
<li>runners/konquerorsessions/konquerorsessions.cpp <span style="color: grey">(f2e437a)</span></li>
<li>runners/konquerorsessions/konquerorsessions.desktop <span style="color: grey">(df81780)</span></li>
<li>runners/konquerorsessions/konquerorsessions.h <span style="color: grey">(957f976)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>