<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107703/">http://git.reviewboard.kde.org/r/107703/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2012, 2:36 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is a quite big regression so something has definitely to be done yeah...
looking at this part i'm a bit hesitant about exposing themepath in this component, because it would be needed pretty much just there.
luckily the systray has a c++ part, so
another option would be creating the custom iconloader in the c++ part of the systray, then set the icon as a QIcon in the iconitem.
opinions?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">from a QML POV passing a QIcon from the systray protocol to the item would probably be nicer, it however means earlier path resolution and thus reduced flexibility form that point on (not that it matters as it can be added later, just saying... :))</pre>
<br />
<p>- Harald</p>
<br />
<p>On December 13th, 2012, 2:19 p.m., Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 2:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also see https://git.reviewboard.kde.org/r/107702/
KSNI: fix IconThemePath support
IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.
Fix:
- IconItem has a new property themePath which will update a custom icon
loader
- Use the iconloader to get a KIcon when necessary
- Trigger icon updates when either the source (name/data...) or the theme
path changes
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772
BUG: 311555
CCMAIL: 1088772@bugs.launchpad.net</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">regular KSNI: works (juk, kmix, klipper..)
QSTI providing SNI via sni-qt: works (mumble)
QSTI using xembed: works (mumble)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311555">311555</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/iconitem.h <span style="color: grey">(16513b0622e8f3910db11642be85794a9bf0418e)</span></li>
<li>plasma/declarativeimports/core/iconitem.cpp <span style="color: grey">(765e7eddac53fc4a6e3a1704ffff581b240e4c72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107703/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>