<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107428/">http://git.reviewboard.kde.org/r/107428/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 26th, 2012, 9:35 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is really an issue that needs addressing, thanks for taking time for it.
i'm very in favor of removing all those hardcoded sizes from the code.
however i see two problems with that approach
1) icons are cleanly painted only when they have a size that is the "right" one (16,22,32,48,64,128,512 exported in qml with theme.smallIconSize, smallMediumIconSize etc) for big sizes doesn't matter if the pixmap ends up being scaled, but small icons really look horrible when scaled (and in the new code there is no check the size ends up being one of those).
2) it's anyways quite arbitrary, so i can easily see each plasmoid using more or less its own logic, with the end result looking a bit like a patchwork.
the"proper" solution i think is to export in Theme the configurable KIconLoader sizes, (Desktop, Toolbar, SmallIcons etc) and those can be controlled by a kcm, so will be properly set on higher resolution displays</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just added the bindings:
use
theme.iconSizes.dialog for most icons
theme.iconSizes.toolbar for unmount
theme.iconSizes.small for all that is normally 16x16
so the icon settings in systemsettings will affect those icons</pre>
<br />
<p>- Marco</p>
<br />
<p>On November 23rd, 2012, 10:11 p.m., Michael Zanetti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2012, 10:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution screens.
The patch changes also one label from wordWrapping to clipping behavior because otherwise it messes up the layout.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on High res screen at full DPI and at regular DPI values</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml <span style="color: grey">(3087a07)</span></li>
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span style="color: grey">(1fab0ef)</span></li>
<li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml <span style="color: grey">(f8728d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107428/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>